Tool not works with mogoose models when model and collection names are different about migrate-mongoose HOT 4 CLOSED

@vologab I suggest not using this('model2') and require ing directly into your migration. I used to think it was a good idea to make this('model') available to the migrator, but I don't think the migrator should know about any models, let alone registering them on a separate mongoose connection.

I can fix this, but I'm thinking of removing that feature.

Your code should be handling that because all a migration framework should do is run migrations.

What do you think? @vologab

from migrate-mongoose.

@balmasi But if I will create separate connection, how I can obtain connection settings from migrator config?

from migrate-mongoose.

@vologab mmm good question.

My question in response is, why is that necessary?

You're assuming everyone wants their models to exist on the same db as their migrations db.

I think the config should only be to tell the migrator what DB/collection to use to WRITE and READ migration states, not the db your app models are registered.

Wouldn't you have your connection settings from the environment your code runs in? for example, If running migrations in prod, your models should already be registered using the prod connection in your code (from your environment variables or a similar mechanism)

Please let me know if you think I'm missing something

from migrate-mongoose.

Closing this because I think I've allowed enough time for discussion.

TLDR; I think the migrator should open an independent connection to the database rather than making assumptions about the database configurations of the user

from migrate-mongoose.