Comments (8)
- I disagree about
.hold
on a customer. You should perform ahold
on aCard
, not on acustomer
. - Also if you have an
add_card
method, there should be aremove_card
method. I think the proper name should beassociate_card
anddeassociate_card
.
from balanced-python.
hold
should at least be a helper.
I posit that most customers will have a single valid card associated at any given time. Writing customer.hold
is much easier for the person integrating Balanced than writing card = customer.cards.filter(is_valid=True)[0]; card.hold
.
from balanced-python.
- We return a primary source uri don't we?
I would write a property that will return a most_recently_added_card
and
a most_recently_added_bank_account
On Mon, May 6, 2013 at 2:51 PM, Marshall Jones [email protected]:
hold should at least be a helper.
I posit that most customers will have a single valid card associated at
any given time. Writing customer.hold is much easier for the person
integrating Balanced than writing card =
customer.cards.filter(is_valid=True)[0]; card.hold.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-17510631
.
from balanced-python.
default_card
/default_bank_account
? How does most_recently_added...
work with setting cards/bank_accounts to invalid?
from balanced-python.
most_recently_added_bank_account
should just be default_bank_account
where the order of items returned is:
- whatever was set to default
- most recent, valid card
same for cards.
from balanced-python.
That is perfect for me. Can we call it "active_card" and "active_bank_account" then?
from balanced-python.
Implementing in #36
from balanced-python.
Done!
from balanced-python.
Related Issues (20)
- Write a test for sideloading
- BankAccount object '.bank_account_verification' returns a Resource instead of BankAccountVerification object HOT 3
- BankAccount bank_account_verification field HOT 1
- Card.associate_to_customer(customer) fails HOT 8
- Pagination for queries is broken in Python client HOT 3
- Is our version schema correct (for pip)? HOT 4
- The NoResultFound should be the one in balanced rather than wac
- Getting page object when it is only a single element.
- Source on debit coming back as resource type instead of card/bank account
- Failed to handle doesn't exist resource correctly HOT 11
- Push to card specs and scenarios
- associate bank account scenario using cards instead
- Limit on query filter is broken. always returns all objects HOT 1
- Exception Type for NoResultFound is incorrect
- Run examples as part of test run HOT 2
- Error messages not descriptive
- Make marketplace funding instrument transactions more convenient
- Ensure we cover the same test scenarios as the ruby client
- Run test results through a validator
- Resource query all to a empty list bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from balanced-python.