Git Product home page Git Product logo

Comments (10)

wenweihu86 avatar wenweihu86 commented on May 17, 2024

@MrKingHH Sure! Would you please help contribute it? If not, we can do it.

from starlight.

MrKingHH avatar MrKingHH commented on May 17, 2024

I am very happy to do this. I will use my spare time to try my best to finish the work.

from starlight.

wenweihu86 avatar wenweihu86 commented on May 17, 2024

Thanks very much! please commit your codes to proto3 branch.

from starlight.

MrKingHH avatar MrKingHH commented on May 17, 2024

I only changed some files, why there 122 files changed...

from starlight.

jovany-wang avatar jovany-wang commented on May 17, 2024

@wenweihu86 What's the purpose to merge the changes of pb3 to proto3 branch?

Why not request a PR to master directly?

If there're many changes that we should merge to proto3 branch, I'd like to split the changes to many small PRs and merge them into master. one by one.

Look forward to your reply.

from starlight.

wenweihu86 avatar wenweihu86 commented on May 17, 2024

@jovany-wang we need master to be protobuf 2.5, because it is the main stream version in baidu.

from starlight.

wenweihu86 avatar wenweihu86 commented on May 17, 2024

@MrKingHH I add some comments for you pull request.

from starlight.

MrKingHH avatar MrKingHH commented on May 17, 2024

image
image
I have set complie jdk version in root pom.xml file. But when i run mvn test, the errors above are reported. I cann't figure it out just now. Can u tell me how to slove this problem?
@wenweihu86
Look forward to your reply!

from starlight.

wenweihu86 avatar wenweihu86 commented on May 17, 2024

@MrKingHH upgrading the jprotobuf version will resolve it.

from starlight.

wenweihu86 avatar wenweihu86 commented on May 17, 2024

master has supported protobuf 3.x

from starlight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.