Forked buttons not rendering on github about pypipins HOT 11 CLOSED

I would suggest it has something to do with it not being a valid image extension. Edit your URLs so you always end in something like /badge.png like the badges for pypipins do.

from pypipins.

Ah yeah I will try.

from pypipins.

@kura

Now the problem is in the route. Because I want the URL in route, flask won't be able to tell if the format is part of the URL or not.

Example:

http://sopins.herokuapp.com/twitter/png/https://www.google.com

to

http://sopins.herokuapp.com/twitter/https://www.google.com.png

Any way to get around that?

from pypipins.

Your URL scheme is totally messed up. Try using this, for example.

@app.route('/facebook/<fb_type>/<path:url>/pin.<format>', methods=['GET'])

@app.route('/<generator>/<path:url>/pin.<format>', methods=['GET'])

In your URL formatting you had format in the wrong place, you can't change the routing the way you were trying to do it without changing where the arguments are set in the scheme.

The reason you have to return some kind of MIME type at the end of the image URL is because not all browsers, caching systems etc will cache the result (like GitHubs caching layer) based on the Content-Type MIME without the image having a valid MIME extension.

from pypipins.

That makes sense. But this still doesn't seem to work for some reason (karan/sopins@2da6ff2).

from pypipins.

I cloned your repository and tested those lines myself before I wrote my response, so they really do work. I'll do a pull request of my changes for you.

from pypipins.

Pull request done. As a note, your code was looking for badge.<extension> but were trying to access pin.<extension>

from pypipins.

I'm not sure what you are referring to, but in my latest commit, on this line https://github.com/karan/sopins/blob/2da6ff2126a932477e5ce9caa027f020c7014302/pins.py#L95 I look for pin.<format>. then in my README, I refer the same URL, but the CDN fails to get the image.

I tried your PR too, but it doesn't seem to work on Github.

from pypipins.

You're returning an invalid content-type header.

GET /twitter/https://kura.io/pin.png HTTP/1.1                        
Host: sopins.herokuapp.com

HTTP/1.1 200 OK
Content-Type: png
Date: Sat, 07 Jun 2014 20:00:43 GMT
Server: gunicorn/18.0
Content-Length: 1149
Connection: keep-alive

from pypipins.

Oh crap. Well that fixed it. Thanks

from pypipins.

Any time.

from pypipins.