Git Product home page Git Product logo

Comments (10)

Shing-Ho avatar Shing-Ho commented on June 3, 2024

Hi team.
This is the first time working on this project. So I don't know well about this project.
So I could find the DIGG page already but I don't know what's DIGG roi and also what I have to work for monthly and which yearly did you meant.
So if you could provide me details that would be great!

from v2-ui.

m4azey avatar m4azey commented on June 3, 2024

This issue refers to the DIGG ROI on the main sett page

from v2-ui.

Shing-Ho avatar Shing-Ho commented on June 3, 2024

I cannot find that in the main setting page too. Could you post screenshot?

from v2-ui.

Shing-Ho avatar Shing-Ho commented on June 3, 2024

image
Did you mean this page?

from v2-ui.

Shing-Ho avatar Shing-Ho commented on June 3, 2024

I found Yearly ROI from the app.badger.finance. Do you know why I am not getting the table in the local?

from v2-ui.

Shing-Ho avatar Shing-Ho commented on June 3, 2024

Sorry, it's showing in my local. I am still not understand about this issue. I can find the MONTH/YEAR combo in the above table and if I change that Yearly ROI becames Monthly ROI. So you mean I will need to show Yearly ROI and Monthly ROI at the same time?
image

from v2-ui.

Shing-Ho avatar Shing-Ho commented on June 3, 2024

Now, I understand the bug and I can see I am getting 19.63% for MONTH and 256.13 for YEAR.

v2-ui/src/components/Collection/TokenCard.tsx

Line 74 in 5d803e0

? simulateDiggSchedule(vault, tokens[deploy.digg_system.uFragments.toLowerCase()])

But in this code if the token's address is DIGG then it is calling simulateDiggSchedule.

v2-ui/src/mobx/reducers/statsReducers.ts

Lines 227 to 231 in 5d803e0

export function simulateDiggSchedule(vault: Vault, digg: Token) {
let dps = new BigNumber(0.000031442 * 60 * 60 * 24 * 360);
return dps.multipliedBy(digg.ethValue).dividedBy(vault.holdingsValue()).multipliedBy(1e2).toFixed(2) + '%';
}

This is the simulateDiggSchedule function.
In that function, it is calculating the value not depending on the roi that we are getting. So that's why it's same. I don't know about the logic so I don't know what's wrong in that function? Anybody could review this function and let me know?

from v2-ui.

m4azey avatar m4azey commented on June 3, 2024

Yeah, so this function was a placeholder for the actual result that comes from our subgraph's pricePerShare values.

from v2-ui.

m4azey avatar m4azey commented on June 3, 2024

I think you'd either simulate the monthly schedule or see if the actual schedule is returning correctly

from v2-ui.

Shing-Ho avatar Shing-Ho commented on June 3, 2024

#101
Please review this pr.

from v2-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.