Comments (6)
I'd say EventStream.end() should be renamed, because the name is quite ambiguous. Event I didn't remember what it was for :) In the context of the implementation of sampledBy it looks fine though
changes().takeUntil(sampler.end()
How about replacing it with a mapEnd(f)
function that would work similarly to mapError
? It would make the API more consistent, even though in mapEnd you'd almost always use a constant instead of a function.
from bacon.js.
Oh, mapError actually only existed on my machine :) Just pushed it to Github. Still, I think we should add a similar mapEnd method for consistency.
from bacon.js.
Created a new branch "mapEnd". How do you like it?
from bacon.js.
mapEnd
makes sense as the value can be given as argument to the method. 👍
from bacon.js.
Ok then. It's all yours!
from bacon.js.
I redefined mapEnd to be consistent with map
and mapError
, i.e. it passes through all events other than End.
from bacon.js.
Related Issues (20)
- flatMapLatest(Bacon.once) is unlike flatMap(Bacon.once) HOT 2
- doLog on Bus HOT 4
- J Query Cannot read property 'label' of undefined HOT 2
- Bacon.when doesn't respect the syncronization pattern, unless I subscribe to the source stream
- Shorthand for filter map HOT 4
- TypeScript import doesn't work HOT 1
- examples are not working HOT 3
- Property current value handling in case of re-activation HOT 3
- Bacon.js 4.0 HOT 14
- Converge ES6 module imports for browser and Node.js HOT 1
- Remove dist directory from git HOT 1
- Event type guards HOT 7
- Internet Explorer problem as of version 3.0.17 (minor upgrade) HOT 3
- Travis needs to be replaced
- flatMapLatest spawns next substream before the previous is disposed HOT 1
- 'Property<string>' is not assignable to type 'Property<string | null>' HOT 3
- Cannot use JS objects which throw on undefined property access
- .withLatestFrom(later(1, "foo"), …) depends on JS runtime HOT 1
- examples.html is not working - ReferenceError: Bacon is not defined HOT 1
- ObjectTemplate type issue with Date objects HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bacon.js.