EventStream.takeUntil spec test incorrect? about bacon.js HOT 3 CLOSED

EventStreams never send Initial events, only Properties do that. I'll have
to take a look at the code to comment on takeUntil specs though.

-juha-

On 8.2.2013, at 0.37, Freezerburn [email protected] wrote:

According to your documentation for takeUntil, it stops when it sees a Next
event, specifically. However, your test for this EventStream requires that
either: Bacon.repeatedly immediately sends an Initial event, or that
takeUntil should stop upon an Initial event as well.

The way my JBacon library originally implemented everything, it would send
the Initial event after the given delay to repeatedly, so the actual values
the test should have expected would have been [1, 2, 3, 1] when takeUntil
stops upon a Next event. I had to change my code so that the Initial event
is sent immediately, and the amount of time before the stopper fires needed
to be 5 in order to get the same expected values.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/77.

from bacon.js.

Excerpt from the specification:

describe "EventStream.takeUntil", ->
  it "takes elements from source until an event appears in the other stream", ->
    expectStreamEvents(
      ->
        src = repeat(3, [1, 2, 3])
        stopper = repeat(7, ["stop!"])
        src.takeUntil(stopper)
      [1, 2])
it "includes source errors, ignores stopper errors", -> expectStreamEvents( ->
      src = repeat(2, [1, error(), 2, 3])
      stopper = repeat(7, ["stop!"]).merge(repeat(1, [error()]))
      src.takeUntil(stopper)
    [1, error(), 2])

In short, it is specified that the result stream ends when a Next event appears in the "stopper". Errors in sourse are passed through. Errors in the stopper are ignored. EventStreams never contain Initial events so they are not specified at all.

To me this seems clear. Could you explain the problem again? :)

from bacon.js.

Aah, the problem I was having is that I thought EventStreams sent Initial events. Not having to send those is gonna make some of my code a bit cleaner. My bad :)

from bacon.js.