Git Product home page Git Product logo

Comments (17)

raimohanska avatar raimohanska commented on July 20, 2024

Oh and where to put the generated javascripts. So far it's worked ok to host them on github too. At least I like them to be easily available and up to date. Any other ideas for how to generate/host these files?

from bacon.js.

eskimoblood avatar eskimoblood commented on July 20, 2024

So we still can remove the assert using grunt. We can define a custom tasks for this. We coud also run the test with grunt, but I'm not sure if this is necessary. Using npm test is also the command that travis uses to run the test by default.

For generated files, whats wrong on hosting them from github. Also the homepage could just gh-pages branch. And a grunt task that generates the files from the markdown documents.

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

I guess it's best to keep the generated files on github in the future too. However I find it a bit odd to put generated files to lib/ with jquery, maybe dist/ would be more intuitive dunno. Anyways it's a minor thing.

from bacon.js.

eskimoblood avatar eskimoblood commented on July 20, 2024

👍 for dist/, lib/ only for jquery. I work on removing the assertion with grunt, so we can skip the cake file, will change this as well.

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

Btw it seems that the world is not ready yet for grunt 0.4.x. Contrib plugins seem to work out-of-the-box but e.g. grunt-shell or grunt-exec fail. They work like a charm with latest 0.3.x. Should consider switching to 0.3.x unless we want to live on the bleeding edge.

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

+1 for ditching Cakefile in favor of grunt.

from bacon.js.

eskimoblood avatar eskimoblood commented on July 20, 2024

Made a pull request #65

from bacon.js.

raimohanska avatar raimohanska commented on July 20, 2024

Merged. Now there's still something amiss? I did

npm install
./grunt

And the result is

>> Local Npm module "grunt-contrib-copy" not found. Is it installed?
Warning: Task "copy" not found. Use --force to continue.

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

Same for me. It's because grunt-contrib-copy has no specific version, instead it references current master (https://github.com/gruntjs/grunt-contrib-copy/archive/master.tar.gz). npm-shrinkwrap ignores the dependency for this reason (?). If you rm npm-shrinkwrap.json && npm install && ./grunt should work fine. However, I hope there is a way of specifying the version for grunt-contrib-copy so that we could continue using npm-shrinkwrap. I guess this would just work with grunt 0.3.x..?

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

To clarify: npm install ignores package.json if npm-shrinkwrap.json is present.

from bacon.js.

eskimoblood avatar eskimoblood commented on July 20, 2024

So I think the best should be to go back to grunt 0.3.

from bacon.js.

raimohanska avatar raimohanska commented on July 20, 2024

Sounds fair.

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

Ok if I do this?

from bacon.js.

eskimoblood avatar eskimoblood commented on July 20, 2024

I've just started.

from bacon.js.

mileskin avatar mileskin commented on July 20, 2024

👍 go for it.

from bacon.js.

raimohanska avatar raimohanska commented on July 20, 2024

#66 Merged. Now it seem to work fine.

I put /dist under version control for now, as there's no other distribution mechanism for the pre-built javascripts.

I updated references in [readme,package.json,component.json] to point to dist instead of lib.

I published 0.0.12

from bacon.js.

raimohanska avatar raimohanska commented on July 20, 2024

Now that readme is updated, this can be closed. Thanks guys!

from bacon.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.