JoSS Review: Example Usage about recan HOT 5 CLOSED

The author should also specify how users can access the example datasets. Otherwise, the following line of code would be confusing for inexperienced users: sim_obj = Simgen("./data/hbv_C_Bj_Ba.fasta").

On a side note, I guess the author have changed the name of the data folder in their Github repository into datasets. So, it may need to be changed in the example code too.

from recan.

The first screenshot showing similarity plot is annotated : https://raw.githubusercontent.com/babinyurii/recan/master/pictures/HBV_1_rec_C_B_annotated.PNG

Link to the dataset folder is added to README (right before the examples), and the statement sim_obj = Simgen("./data/hbv_C_Bj_Ba.fasta is changed to sim_obj = Simgen("./datasets/hbv_C_Bj_Ba.fasta
https://github.com/babinyurii/recan

from recan.

@babinyurii: I can see that you have updated your figures and your example code. But I do not see where you have specified the download link to your example datasets. Did you forget to push your commit?

from recan.

Thanks for comment, @lamhm. Now I've added the link to download the example datasets. It's in the section example datasets which is right above the references section.

from recan.

Thanks a lot, @babinyurii. The example usage looks great now.

@betteridiot - If you do not have any additional concerns, I think you can close this issue.

from recan.