[Bug] Winhighlight is passed on to quickfix window about incline.nvim HOT 7 CLOSED

By the way, I will be pushing quite a few changes soon, including better highlight support so that you won't need to use winhl. And thank you very much for the kind words!

from incline.nvim.

This is very interesting. It seems to be a Neovim bug. I can reproduce it with no plugins, like so:

1. nvim --clean
2. :lua vim.api.nvim_win_set_option(vim.api.nvim_open_win(vim.api.nvim_create_buf(false, true), false, { relative = "editor", width = 1, height = 1, row = 1, col = 1 }), "winhighlight", "Normal:Search")
3. :copen

I've opened a neovim issue: neovim/neovim#18283

from incline.nvim.

@b0o thanks for looking into this and raising the issue in neovim core 👍🏿 , just tried out the new API, and it works great, doesn't leak into the quickfix any more 💯. Will close this out now then.

from incline.nvim.

@b0o like you've figured out, the problem is caused by the fact that both
nvim_win_set_option and nvim_buf_set_option do not behave like
:setlocal, even though that's how they're intended to work. I was fighting
with this bug for a while in my plugin diffview. Essentially, contrary to
when using :setlocal, setting options in a window A with nvim_win_set_option
and then creating a new window B from that window, B will inherit all window
options from A including those set with nvim_win_set_option.

I found that the simplest way to get around this is to just create a wrapper
around :setlocal. I've been using this wrapper in both my plugins, and I've
had no problems with this bug ever since (this code uses some ugly polymorphic
parameters, but I just really enjoy the convenience of overload signatures).

from incline.nvim.

Hey @sindrets, thank you for sharing! I just wrote a wrapper inspired by yours, it seems to have fixed the issue for me.

Before I merge those changes into main, I am curious to know what the purpose of no_win_event_call is, and if it is necessary in this case? I just tested the following to see if nvim_win_call triggers those events, but when I run these two commands I don't see any "event" messages:

• :au WinEnter,WinLeave,WinNew,WinClosed,BufEnter,BufLeave * echom "event"
• :lua vim.api.nvim_win_call(1002, function() vim.cmd [[setlocal winhighlight=Normal:Search]] end)

from incline.nvim.

@b0o Ah, it seems you're right: setlocal doesn't seem to trigger any of
these events, and it's probably only there due to an oversight. Thank you for
pointing that out!

Finding out what does and doesn't trigger these events can
be a bit surprising sometimes, so I've probably used this function a bit too
liberally. It has notably improved performance for me in instances where I'm
changing buffers multiple times in multiple windows over a short time span.

from incline.nvim.

@sindrets Cool, just wanted to make sure!

@akinsho I've merged the fix into main, would you mind giving it a try for me?

from incline.nvim.