Git Product home page Git Product logo

Comments (8)

pianocomposer321 avatar pianocomposer321 commented on August 26, 2024 3

@akinsho I just want to clarify, because I know this has gotten a bit confusing, and I think my last comment probably is the source of a lot of it. There are actually a total of three options being discussed right now - focused_win, which already exists, and two more (I'll just make up names because they haven't been implemented yet): last_win and last_nonignored_win. The final two are the ones that I was saying I think should be two separate options, with the latter being the one I thought was more important if only one of them gets implemented. I completely agree that focused_win should be left as-is.

from incline.nvim.

pianocomposer321 avatar pianocomposer321 commented on August 26, 2024 2

Just to chime in, I'm not currently using this plugin (though I am planning to give it a shot), but I can imagine situations where I wouldn't want it to be hidden every time a window is focused, only when there's only one window open. For example, when the top window of a horizontal split is focused, just looking at the bottom of that window is easier and more intuitive than looking all the way at the bottom of the screen, so I probably wouldn't want the status line hidden in that case. But if there's only one window open, the floating status line is going to be redundant, and the bottom of the window is where the main status line is anyway. So I still think it would be helpful for this to be an additional option.

from incline.nvim.

akinsho avatar akinsho commented on August 26, 2024 2

Just jumping in regarding the two separate options. I'm currently using the plugin and really enjoying it with the current focused win option I'd much rather retain the current behaviour, i.e. the buffer I'm in should never have a label since my statusline will always show it. Trying not to muddy the waters but advocate for a different option that does what @pianocomposer321 proposed but also keeping the ability to have the plugin behave as it currently does.

from incline.nvim.

b0o avatar b0o commented on August 26, 2024 1

That is a great point and I agree, @pianocomposer321. I’ll add this to the backlog.

from incline.nvim.

pianocomposer321 avatar pianocomposer321 commented on August 26, 2024 1

Hmm...that is an interesting question.

TBH, I feel like this would be good as two separate options. Or an option with an "enum"-style value. But if you don't want to implement two separate options (or just one at a time), I think that it should be hidden when it's the last non-ignored window. The main issue with this would be if a window is ignored with incline but not for the main statusline (meaning that when it's focused you wouldn't be able to tell the name of the file in the non-ignored window), but leaving that up to the users to fix doesn't seem entirely unreasonable.

Of course, having two separate options still seems like the best approach to me.

from incline.nvim.

gegoune avatar gegoune commented on August 26, 2024
  hide = {
    focused_win = true,
  },

should take care of single window, shouldn't it?

from incline.nvim.

b0o avatar b0o commented on August 26, 2024

Yeah the option @gegoune mentioned should work. Give it a try and let me know if that’s what you’re looking for?

from incline.nvim.

b0o avatar b0o commented on August 26, 2024

Does anyone have thoughts on how this proposed option should behave when there is more than one window, but only one non-ignored window?

For example, if you open the file foobar.lua in one window and nvim-tree in another window, and if you have ignore.buftypes = "special", then there would effectively be only one non-ignored window. If the proposed option was enabled, should Incline be shown or hidden on the foobar.lua window?

from incline.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.