Parsing of image substitution incomplete about k8s-deploy HOT 7 CLOSED

That's a good catch. @SamMousa would you be willing to raise a fix for the same?

from k8s-deploy.

Cool. Tag @shigupt202 in your PR so he can take it forward. :)

from k8s-deploy.

Do you want the quick fix? Because that I can do.

I'm not not able to commit the time to implement the use of a proper yaml parser that just inspects the names of object properties...

Also: do I just update type TS files? Because it seems to me this repository contains both the TS and compiled JS file, which seems a bit redundant to me..

from k8s-deploy.

You need to update the .ts files then locally run npm run-script build. I agree it's a little redundant, but this way we get to validate the unexpected compile changes too; which we can confidently take to our releases branch.

The quick fix should do.

cc: @shigupt202 could you validate how we missed this? I remember we solved this in the ADO task?

from k8s-deploy.

I agree it's a little redundant, but this way we get to validate the unexpected compile changes too

I think it's actually a risk, see #87.

I'll create a PR for the changed regex this week.

from k8s-deploy.

You need to update the .ts files then locally run npm run-script build. I agree it's a little redundant, but this way we get to validate the unexpected compile changes too; which we can confidently take to our releases branch.

The quick fix should do.

cc: @shigupt202 could you validate how we missed this? I remember we solved this in the ADO task?

@DS-MS I can see the fix in ADO task was done in this PR.
Also, in this task we are using yaml parser for updateImagePullSecretsInManifestFiles. But somehow the change was missed for updateContainerImagesInManifestFiles.

from k8s-deploy.

Since this is something you guys have worked on internally; I'll refrain from making a PR for now and let you resolve this for yourselves :)

from k8s-deploy.