Add support for TrafficSplit annotations about k8s-deploy HOT 13 CLOSED

Awesome. We're still in the process of getting our GitHub Enterprise system underway. That'll be my test bed for verifying my changes before submitting the PR since I don't really have any other system with everything wired up. However, I do plan on getting a PR in here so I'll keep this open while I work on it. Thanks!

from k8s-deploy.

@Vidya2606 is actively working on this.

from k8s-deploy.

Unfortunately, no, I don't have docs. The documentation on the adapter is very light and focuses more on the SMI spec than about using the annotations.

It seems like it doesn't really matter though, right? If there's just the ability to set any arbitrary dictionary of annotations on the TrafficSplit, it doesn't matter what the annotations are, I would think. (I had to fork the SMI controller for an internal project and we have added more annotations than what is in the base product. The annotation support here needs to be pretty open, not something where it gets generated or sanity checked based on other parameters.)

from k8s-deploy.

This feature was added to the latest version :). You can use the traffic-split-annotations input. Thanks!

from k8s-deploy.

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

14 days idle seems a little short for feature suggestions. It'd still be good to have this. I haven't moved to GitHub Actions yet but we're targeting that move in my organization for Q1 2022. In the meantime I've forked the baked-in AzDO task and have to own that for the next several months. I can get a PR in for this but it'd be nice to hear from the team if it's interesting before I invest the time.

from k8s-deploy.

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

It would be nice to hear if this is interesting to the team before doing to work to create a pull request.

from k8s-deploy.

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

Hi @tillig. We'd love this feature. Please feel free to create a PR.

from k8s-deploy.

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

@tillig do you have any links to documentation talking about using the annotation for Istio SMI adapter? I can see it in the code but I'm struggling to find docs.

from k8s-deploy.

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.