Support different manifest delimiters about k8s-deploy HOT 9 CLOSED

I have raised a PR to support both commas and new line as delimiters. @SamMousa and @uzi0espil, I believe this should address your use case

from k8s-deploy.

Thanks for the quick release @Ganeshrockz. Tested right now and it's working like a charm!

from k8s-deploy.

+1, I am working on a similar thing, but instead of setting a environment variable, I would get the list from shell script and assign it to a variable. then use that variable in k8s-deploy:

      - name: Get Manifests List
        id: get_manifests
        run: |
          chmod +x "${GITHUB_WORKSPACE}/.github/scripts/list-manifests.sh"
          echo ::set-output name=MANIFESTS::$("${GITHUB_WORKSPACE}/.github/scripts/list-manifests.sh")

      - name: Deploy to Cluster
        uses: azure/k8s-deploy@v1
        with:
          manifests: |
            ${{ steps.get_manifests.outputs.MANIFESTS }}
       ....

The output of list-manifests joins the array of manifests by delimiter \n.

echo ${arrManifests[@]} | tr ' ' '\n'

But it still doesn't work.

from k8s-deploy.

Thanks for having implemented and merged the fix.

In the meantime, while the code is not yet released, what is the best way to use it?

from k8s-deploy.

Can't you just use @master as a version or something?

from k8s-deploy.

Unfortunately, main branch doesn't contain the lib/ directory:

• https://github.com/Azure/k8s-deploy

from k8s-deploy.

Apologies for the delay. I forgot to port the fix to releases branch. Once I do that you can access the fix with the v1 tag. I am on it now

from k8s-deploy.

Great, thanks a lot. Please let me know once done and I'll give a try.

from k8s-deploy.

@tgdfool2 Can you try using the v1 tag now?

from k8s-deploy.