Git Product home page Git Product logo

Comments (8)

thesattiraju avatar thesattiraju commented on July 29, 2024 1

@koushdey inorder to support this, perhaps we could change the logic of throwing the error into a warning instead.

k8s-deploy/src/run.ts

Lines 43 to 47 in acd12a4

function checkClusterContext() {
if (!process.env["KUBECONFIG"]) {
throw new Error('Cluster context not set. Use k8ssetcontext action to set cluster context');
}
}

from k8s-deploy.

japsu avatar japsu commented on July 29, 2024 1

@koushdey My actions runner is running in a pod in a Kubernetes cluster. That pod is running on a service account that has the required access. If I were to run kubectl commands in that pod, they would use the Kubernetes credentials supplied to the pod by Kubernetes and succeed. k8s-set-context with the service account method asks for information that is not relevant or which I do not have in this use case.

from k8s-deploy.

koushdey avatar koushdey commented on July 29, 2024

@N-Usha Any chance you had a look into it?

from k8s-deploy.

github-actions avatar github-actions commented on July 29, 2024

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

koushdey avatar koushdey commented on July 29, 2024

@japsu For running kubectl cmds we need to set context. How will you authenticate the kubectl cmds? k8s-set-context makes use of service account as well to set this context. Have you considered using this action?

from k8s-deploy.

thesattiraju avatar thesattiraju commented on July 29, 2024

@koushdey so this way, when you convert this check into a warning, kubectl cli tool would float up the failures related to lack of k8s context.

from k8s-deploy.

github-actions avatar github-actions commented on July 29, 2024

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

koushdey avatar koushdey commented on July 29, 2024

Changes are merged. Closing issue

from k8s-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.