Git Product home page Git Product logo

Comments (7)

thesattiraju avatar thesattiraju commented on July 29, 2024 2

Yes it can done.

from k8s-deploy.

ammohant avatar ammohant commented on July 29, 2024 2

@kmkumaran - yes, annotations can be added/patched to the yaml itself.

from k8s-deploy.

thesattiraju avatar thesattiraju commented on July 29, 2024 1

@kmkumaran the fix for this would require us to revamp our core logic for image substitution and annotations. I'd say we'll wait until it's a valid scenario may be?

FYI: This logic has been in Production in both ADO and Actions for about 2 years now, there weren't any customer reported issues on this front.

from k8s-deploy.

kmkumaran avatar kmkumaran commented on July 29, 2024

@ajinkya599 , @DS-MS - This came up in a review. Is there a way we can make annotation as part of deployment itself?

from k8s-deploy.

kmkumaran avatar kmkumaran commented on July 29, 2024

@ammohant , when is this fix planned?

from k8s-deploy.

github-actions avatar github-actions commented on July 29, 2024

This issue is idle because it has been open for 14 days with no activity.

from k8s-deploy.

koushdey avatar koushdey commented on July 29, 2024

This logic has been present for quite some time and have not seen any issue reported around it. Closing it for now until we encounter any issues reported for this.

from k8s-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.