Disable BGP Route Propagation to Spokes about canadapubsecalz HOT 3 OPEN

On Mon, Jul 24, 2023 at 1:34 PM Steve Keeler ***@***.***> wrote: @Jamalzkr <https://github.com/Jamalzkr> & @tredell <https://github.com/tredell> , I did a quick code review of the proposed changes and have two comments: 1. For the line, e.g.: disableBgpRoutePropagation: network.disableBgpRoutesFromVPNGateway Any reason why the configuration variable name does not match the resource property? If there is that is fine, but if not it would be easier to find all matching references based on using the same name for config element as resource property. 1. We'll need additional code changes to handle config schema. Two options: optional vs. required. Either way, the config schema will need to be updated (and up-versioned). If we make the new property Required then that will be a breaking change (to existing configurations) and will necessitate a major version increment for the project (e.g. 2.0.0). If we make the new property Optional then we can introduce as a minor version change (e.g. 1.3.0, 1.4.0, etc.), will still need to adjust the config schema (showing it is available but not required), and will also need to adjust the Bicep code changes here to handle both use cases - it has been specified & it has not been specified, in the config. — Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A76MJUXD2FILTJELSRNQBOTXR2WZXANCNFSM6AAAAAAYG5XHS4> . You are receiving this because you were mentioned.Message ID: ***@***.***>