Comments (3)
@Jamalzkr & @tredell , I did a quick code review of the proposed changes and have two comments:
- For the line, e.g.:
disableBgpRoutePropagation: network.disableBgpRoutesFromVPNGateway
Any reason why the configuration variable name does not match the resource property? If there is that is fine, but if not it would be easier to find all matching references based on using the same name for config element as resource property.
- We'll need additional code changes to handle config schema. Two options: optional vs. required. Either way, the config schema will need to be updated (and up-versioned). If we make the new property
Required
then that will be a breaking change (to existing configurations) and will necessitate a major version increment for the project (e.g. 2.0.0). If we make the new propertyOptional
then we can introduce as a minor version change (e.g. 1.3.0, 1.4.0, etc.), will still need to adjust the config schema (showing it is available but not required), and will also need to adjust the Bicep code changes here to handle both use cases - it has been specified & it has not been specified, in the config.
from canadapubsecalz.
from canadapubsecalz.
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.
from canadapubsecalz.
Related Issues (20)
- Error running logging pipeline HOT 1
- Enable and configure the compliance over time workbook in Defender for Cloud HOT 2
- Baseline Cost evaluation / Approximate cost per pipeline HOT 1
- Non-Compliant policies / Subnets should be associated with a Network Security Group HOT 2
- Fix path normalization bug in deployment scripts
- Fix subscription filtering bug in deployment scripts
- CanadaPubSecALZ configuration JSON schema support for editors HOT 1
- Scripts to generate CanadaPubSecALZ configuration files using existing environments as template HOT 1
- Deploy landing zones to new Azure subscriptions in new primary tenant HOT 1
- alz-05 (machinelearning-1) deployment fails HOT 6
- Include VERBOSE output in New-AlzDeployment.ps1 when/where Run-Workflows.ps1 is invoked HOT 1
- Machine Learning archetype deployments failing (x4) HOT 7
- Configure new Azure DevOps organization for testing CanadaPubSecALZ HOT 1
- EventGrid/EventSubscription not supported for Diagnostics Settings to Log Analytics HOT 1
- PrivateLink DNS Registration - MySQL Flexible Server
- Re-organize the main config YML file for clarity and legibility HOT 1
- RFC 6598 HOT 7
- GitHub Actions with RunWorkflows.ps1 does not work after Az module new version release HOT 1
- replace json(null) with null in bastion.bicep HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from canadapubsecalz.