Not able to send message after using subject in MessageProperties about azure-uamqp-python HOT 9 CLOSED

Unfortunately I will have to restrain myself from testing this for a couple of days as I have other pressing matters to handle. I will get there soon though! :)

Thanks again for your help!

from azure-uamqp-python.

Thanks for the report @mi-dst!

You're right - this does appear to be a bug - as we are converting the subject property into an AMQP encoded object when it should be a string/bytes.

I will get a patch out asap :)

As an aside - you shouldn't need to call get_properties_obj - this is used internally to attach the properties to the message before sending.

Thanks again!

from azure-uamqp-python.

Ah, yes. I am not using get_properties_obj() normally. I just tried to make the problem as easy to reproduce as possible for you, but thanks for looking out for me :)

I will keep my eyes peeled for the patch.

Thanks for your quick feedback!

from azure-uamqp-python.

Thanks for your patience @mi-dst - v1.0.1 is now released with a fix. :)

from azure-uamqp-python.

Thanks for the quick update. However I am sad to report that I still cannot seem to get the subject-property working. I do get a different error with 1.0.1 though.

When sending a message I now get:

DEBUG:uamqp.client:Message error, retrying. Attempts: 1, Error: ClientMessageError("ErrorCodes.ClientError: 'bytes' object has no attribute '_c_value'")

Again I believe the quickest way to test it is:

props = uamqp.message.MessageProperties(subject='hello')
props.get_properties_obj()
Traceback (most recent call last):
File "", line 1, in
File "C:\uamqp-test.pyenv\lib\site-packages\uamqp\message.py", line 752, in get_properties_obj
self._set_attr('subject', properties)
File "C:\uamqp-test.pyenv\lib\site-packages\uamqp\message.py", line 741, in _set_attr
setattr(properties, attr, attr_value)
File ".\src/properties.pyx", line 142, in uamqp.c_uamqp.cProperties.subject.set
AttributeError: 'bytes' object has no attribute '_c_value'

Sorry for bringing you bad new just before the weekend...

from azure-uamqp-python.

That's strange - I wonder why my test didn't catch that...
Doh... okay - another patch on it's way....

from azure-uamqp-python.

I'm hoping to include this patch with a couple of other small fixes - release should be out sometime this coming week. Thanks again for your patience :)

from azure-uamqp-python.

Sounds great! Thanks for the feedback!

from azure-uamqp-python.

Okay - this should now actually be resolved in 1.0.2 :)
I actually found some issues in setting a couple of the other message properties as well so a good find!
Sorry it took so long - one of the other changes I wanted to add to this release was giving me headaches.

from azure-uamqp-python.