Use AnyIO instead of AsyncIO about azure-uamqp-python HOT 10 OPEN

Hi @thedrow - I've taken a look and I don't think there's too much work involved.
However we're are currently discussing internally whether we want to invest further in the C-binding-based project, or whether we want to remove the C layer and replace with a pure-python based implementation (prototype currently ongoing in the pyproto branch).
If we opt for the latter - we could build in AnyIO support from the ground-up.

We are also cautious about taking a direct dependency on the lib - so we we're working through what the implementation look like if it were both fully-compatible with AnyIO as well as standalone.

Will keep this thread updated :)

from azure-uamqp-python.

Thanks @thedrow - yes it is likely we will refactor this imminently.
We're already seeing warnings about the passing around of loop, so I would like to get that cleaned up - although we may not get to it within a given timeframe.

I will do my best to scope out the needed work within the next few days.

from azure-uamqp-python.

Hi @JonasKs!
We are currently rewriting this library in pure Python, with the first preview targeted for early 2022.
Development is progressing in this branch: https://github.com/Azure/azure-uamqp-python/tree/pyproto

Given that we are currently rebuilding from scratch - we will not be making these changes to the C-based implementation of uamqp.
So then the question becomes, will the pure Python version of the library use AnyIO. The first preview will not unfortunately - we wanted to focus our efforts on correct end-to-end implementation of the protocol. In subsequent releases we plan to drop the hard dependency on AsyncIO to allow more flexibility here.
My earlier tests with AnyIO (albeit 2 years ago now) introduced a significant perf regression that prevented us from quickly making the shift earlier and needed deeper investigation.

from azure-uamqp-python.

Awesome! Thanks for the quick reply. Good luck with the release 🚀

from azure-uamqp-python.

I'm not going to work on this until we have a consensus on what needs to be done.
Please address this issue as quickly as possible. Thanks :).

from azure-uamqp-python.

Thanks @thedrow!
We wanted to make these changes about a year ago, but at the time it wasn't easy because we were using some very asyncio-specific features like run_in_executor for which we needed to pass through the event loop.
However I think our dependency on the asyncio loop has now been refactored out, in which case it would be awesome to make this change as you've proposed.

Though I know we're using asyncio.sleep - is trio compatible with that?

from azure-uamqp-python.

Of course it does. Trio also supports running tasks in threads.
AnyIO abstracts sleep as well as most other mechanisms.

Is there any chance you'll refactor this on your own?
If not, where are the tests for the asynchronous code?

from azure-uamqp-python.

@annatisch Any updates?

from azure-uamqp-python.

@annatisch Pinging you once more, with feeling ;)

from azure-uamqp-python.

Hi @annatisch, did you land on anything? 😊

from azure-uamqp-python.