Git Product home page Git Product logo

Comments (4)

kushagraThapar avatar kushagraThapar commented on May 31, 2024

@JakubJablonski2-TomTom In case of network failure, depending on the type of operation, it might be retried if its idempotent. That's why you might get the results, even after the error log. This is not a bug rather just a log message of a failure which got succeeded after a single or multiple retries.

Let me know if you have any additional questions on this, thanks!

from azure-sdk-for-java.

FabianMeiswinkel avatar FabianMeiswinkel commented on May 31, 2024

@kushagraThapar - the question why it is logged as error and not warning still stands I guess?

from azure-sdk-for-java.

JakubJablonski2-TomTom avatar JakubJablonski2-TomTom commented on May 31, 2024

@kushagraThapar - indeed, the "bug" is that this situation is logged as error, while IMHO it should be a warning.

from azure-sdk-for-java.

kushagraThapar avatar kushagraThapar commented on May 31, 2024

I believe the reason this is logged as error is because no response was returned as part of the network call and could be because of multiple cases (timeout, network blip, etc.).
Logging this as error versus warning is a decision that we made, @JakubJablonski2-TomTom its not a bug, rather our decision :) - https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java#L431

That being said, we can change it to warning, I am open to this change.
@FabianMeiswinkel please proceed with the change if you think its appropriate in these cases.

from azure-sdk-for-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.