Comments (2)
This builds on:
from azure-rest-api-specs.
I think we should make the label as specific as possible, and also at least try to align with existing naming conventions. I just wrote down all the complexities of suppressions we have here:
I think we could adopt a convention similar to the sdk-suppresions.yaml
labels
For example, they have BreakingChange-Go-Sdk-Suppression
and BreakingChange-Go-Sdk-Suppression-Approved
.
Given we have:
- tool: TypeSpecRequirement
We could do:
Tool-TypeSpecRequirement-Suppression
Tool-TypeSpecRequirement-Suppression-Approved
.
Later on, if we do e.g. - tool: BreakingChangeCrossVersion
we would do:
Tool-BreakingChangeCrossVersion-Suppression
Tool-BreakingChangeCrossVersion-Suppression-Approved
I am suggesting to prefix this with Tool-
to distinguish it from the two different kinds of suppressions: the AutoRest README.md suppressions
and sdk-suppressions.yaml
. See Azure/azure-sdk-tools#8133 for details.
We probably also should rename SuppresionReviewRequired
to match the new convention. I filed an issue for this:
Note we also need to integrate any newly added suppression labels into the Next Steps to Merge
comment. This can be done in a similar way SuppressionReviewRequired
is currently handled. I provided source pointers to it in this issue.
This relates to:
from azure-rest-api-specs.
Related Issues (20)
- [TypeSpec Requirement] Fail if PR contains handwritten swagger but "stable" contains typespec-generated HOT 1
- Azure cosmos account: No mapped feature in Azure Rest API Spec to enable "Allow access from Azure Portal" for cosmos account https://github.com/hashicorp/terraform-provider-azurerm/issues/25641 HOT 3
- [IC3 ACS Calling ] API Review HOT 2
- [Service Bus - Azure Event Hubs Premium SKU] API Review HOT 2
- [Question] Azure OpenAI 2024-03-01-preview - AssistantEventHandler returns chunk objects instead of delta. HOT 2
- [TypeSpec Requirement] Add date-based suppression expiration mechanism HOT 2
- [TypeSpec Requirement] Add path-based suppression expiration mechanism HOT 1
- [BUG] Missing enum values in AppService - TriggeredWebJobStatus HOT 1
- Document how to add new GitHub checks to the spec PR check suite
- Integrate Armstrong Validation into the spec PR check suite. HOT 9
- [BUG] Service API shouldn't change the casing of tags of Paloalto.NextGenerationFirewallVHubPanorama HOT 1
- [Doc] Add section to "ci-fix.md" for "Different behavior in CI and locally"
- [BUG] device registry tsp definition, wrong operationId in tsp example files HOT 3
- "Breaking Change (Cross-Version)" only reports single line for "incompatible properties" HOT 1
- [IC3 ACS Chat ] API Review HOT 2
- cognitiveservices Deployment real-time percentage usage HOT 1
- [BUG] Non-existant coordinatorServerEdition in DBforPostgreSQL examnples HOT 3
- [Microsoft Azure Data Manager for Agriculture - Microsoft Azure Data Manager for Agriculture] API Review
- [Question]OpenAI Assistant V2 API support & Streaming Support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-rest-api-specs.