Git Product home page Git Product logo

Comments (2)

konrad-jamrozik avatar konrad-jamrozik commented on June 11, 2024

This builds on:

from azure-rest-api-specs.

konrad-jamrozik avatar konrad-jamrozik commented on June 11, 2024

@mikeharder

I think we should make the label as specific as possible, and also at least try to align with existing naming conventions. I just wrote down all the complexities of suppressions we have here:

I think we could adopt a convention similar to the sdk-suppresions.yaml labels

For example, they have BreakingChange-Go-Sdk-Suppression and BreakingChange-Go-Sdk-Suppression-Approved.

Given we have:

- tool: TypeSpecRequirement

We could do:

  • Tool-TypeSpecRequirement-Suppression
  • Tool-TypeSpecRequirement-Suppression-Approved.

Later on, if we do e.g. - tool: BreakingChangeCrossVersion we would do:

  • Tool-BreakingChangeCrossVersion-Suppression
  • Tool-BreakingChangeCrossVersion-Suppression-Approved

I am suggesting to prefix this with Tool- to distinguish it from the two different kinds of suppressions: the AutoRest README.md suppressions and sdk-suppressions.yaml. See Azure/azure-sdk-tools#8133 for details.

We probably also should rename SuppresionReviewRequired to match the new convention. I filed an issue for this:


Note we also need to integrate any newly added suppression labels into the Next Steps to Merge comment. This can be done in a similar way SuppressionReviewRequired is currently handled. I provided source pointers to it in this issue.

This relates to:

from azure-rest-api-specs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.