smoothScrollToPosition crash about carousellayoutmanager HOT 9 CLOSED

Hi @SiminaNicolae
I'll add position check to this code. But generally you should call RecyclerView.smoothScrollToPosition method instead of LayoutManager one.
The other thing that both infinite and non-infinite will crash (I'll add this) if you pass wrong position that is not in [0, adapger.getCount()-1].
Are you agree with this?
Thanks.

from carousellayoutmanager.

@SiminaNicolae
please find this commit 294e16b. If you don't have any objections, I'll create new tag

Thanks

from carousellayoutmanager.

Hi @mig35
Thank you for investigating it. I am not 100% sure that with this fix you will still be able to smooth scroll to left if the centered item from carousel is the first one from the list. I am thinking about the case of infinite scroll carousel where you have to go to the end of the list. (but I am sure that you tested it already ;) )

Thanks

from carousellayoutmanager.

@SiminaNicolae
This works fine if you pass 0 (this will go to the first element). Bug if you pass carouselLayoutManager.getCenterItemPosition() - 1, then it will crash because this will be -1 and there can not be an element with index -1. And this is true for infinite carousel too.
So any way you will have to add code that checks position bounds.

Thanks

from carousellayoutmanager.

Ok...thank you.

from carousellayoutmanager.

Hi SiminaNicolae,
Upload new version with this checks: 1.1.4

from carousellayoutmanager.

dear mig35

i am also having same issue, not able to do smoothScrollToPositon after initializing the view, RecyclerView.State.getItemCount() giving 0 therefore it is firing "position can't be great then adapter items count. ..."

can you please help

from carousellayoutmanager.

I figured out my problem, it was with my code, it is working fine now, thank you

from carousellayoutmanager.

Hi @engzico
We also figured out our problem. Fixed in commit cf4fcb2. Upload new version: 1.1.5

from carousellayoutmanager.