Git Product home page Git Product logo

Comments (6)

ayltai avatar ayltai commented on June 27, 2024

Thank you for letting me know about this. A new release with the same v1 tag has been published to replace the old v1 so there is nothing to change on your side.

from setup-graalvm.

radeusgd avatar radeusgd commented on June 27, 2024

Thanks a lot for the quick response.

We re-run our CI just now, but it seems that somehow it still picks up the old version:
image

I don't know if it may be a caching issue. Possibly GitHub assumes that releases are immutable and caches them for a pretty long time?

Maybe you could try releasing a bumped version too to ensure one can force the new version?

from setup-graalvm.

radeusgd avatar radeusgd commented on June 27, 2024

I investigated this further - updated our CI to pin to the specific commit and the issue still persists.

Relevant part of our config:

      - name: Checkout repository
        uses: actions/checkout@v2
        with:
          # We must fetch at least the immediate parents so that if this is
          # a pull request then we can checkout the head.
          fetch-depth: 2
# [...]
      - name: Setup GraalVM Environment
        uses: ayltai/setup-graalvm@03e7b7557
        with:
          graalvm-version: ${{ env.graalVersion }}
          java-version: ${{ env.javaVersion }}

The error is exactly the same as above:

Run ayltai/setup-graalvm@03e7b7557
Downloading GraalVM from graalvm/[email protected] graalvm-ce-java11-linux-amd64-20.2.0.tar.gz (download)
/bin/tar xz --warning=no-unknown-keyword -C /home/runner/work/_temp/temp_1514993758 -f /home/runner/work/_temp/0c663c3c-5b07-4249-b5d4-d278cccd999e
Error: The `set-env` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. For more information see: github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands
Error: The `add-path` command is deprecated and will be disabled on November 16th. Please upgrade to using Environment Files. For more information see: github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands
/opt/hostedtoolcache/GraalVM/java11-linux-amd64-20.2.0/x64/bin/gu install native-image

I'm not sure what may be causing that, as the source code only seems to use actions/core for this purpose and it was updated. Maybe the artifacts for the release were not re-built? Just guessing though.

from setup-graalvm.

radeusgd avatar radeusgd commented on June 27, 2024

I have looked into the source code in the dist directory inside of the source bundle of the latest release.

It seems that the relevant parts from the actions/core still use the old source code (there is the set-env logic, but no environment files logic).

So my guess is that the action has not been rebuit before publishing and since the dist directory is what is relevant for the GitHub Actions runner, while the new release is published, it still runs the old version.

from setup-graalvm.

ayltai avatar ayltai commented on June 27, 2024

Thanks for getting that deep into the issue. Indeed, that's one of the causes. Another cause was that node_modules was not updated.

I believe it is fixed on the current master branch and the v1 tag.

from setup-graalvm.

radeusgd avatar radeusgd commented on June 27, 2024

It seems to have fixed the issue indeed - the warnings do not show up in our workflows anymore.

Thank you very much for resolving this issue so quickly.

from setup-graalvm.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.