Git Product home page Git Product logo

Comments (3)

AydinAdn avatar AydinAdn commented on May 24, 2024

The issue is that FFmpeg writes to STDERR, so we can only read the output from ErrorDataReceived. This is how we raise progress events and completion events by reading the output and attempting to serialise it,

If FFmpeg exits with errors, it will return an ExitCode of something other than 0 or 1, in such situations the an exception is composed and thrown. You can find the code below in Engine.cs at the end,

if ((this.FFmpegProcess.ExitCode != 0 && this.FFmpegProcess.ExitCode != 1) || caughtException != null)
{
    throw new Exception(
    this.FFmpegProcess.ExitCode + ": " + receivedMessagesLog[1] + receivedMessagesLog[0],
    caughtException);
}

from mediatoolkit.

Japollack avatar Japollack commented on May 24, 2024

That is all fine but instead of throwing a new exception would it not be great if the OnError event is invoked? Ofcourse, if no OnError event handler is attached an exception is thrown.

from mediatoolkit.

AydinAdn avatar AydinAdn commented on May 24, 2024

Ah my bad, I misunderstood you. I like that idea!

If I'm honest... I want to bulldoze the entire thing and rebuild from scratch, sometimes I wonder if I was drunk the entire time I was writing the damn thing.

from mediatoolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.