Git Product home page Git Product logo

Comments (10)

khurshid-alam avatar khurshid-alam commented on July 20, 2024

Does it compile against glib > 2.58.2 ? Remember all tests must pass. At the moment there are gicon regression (see #2) but even with the fix for gicon, then mic out test fails (which is weird because mic-in test passes).

from ayatana-indicator-sound.

tari01 avatar tari01 commented on July 20, 2024

@khurshid-alam

I have GLib 2.58.3 - with that one it builds. Note, however, that my patch ads an option to DISABLE the tests in CMake with -Denable_tests=OFF.

The code we have right now has hardcoded testing enabled, which makes the package depend on all sorts of exotic libraries not really available in Non-Buntu.

from ayatana-indicator-sound.

khurshid-alam avatar khurshid-alam commented on July 20, 2024

That's odd. I am compiling on Ubuntu 19.04, only ubuntu specific library is libunity-dev. But in debian/control, it has hello package so that it can be compiled without it.

Against Glib > 2.58.x

  1. Integration tests fails
  2. With gicon fix it compiles but only external micslider test fails.

Against Glib > 2.60.x

There are lots of errors

  1. gicon fix doesn't work anymore ! though it still works for indicator sound.

  2. I get error like

ActUserManager: user (null) has no username (object path: /org/freedesktop/Accounts/UserTest, uid: 0)

which seems coming from qgetenv("USER"). May be it requires another approach to set user for test environment

volume-control-pulse.vala:745: Unable to connect to dbus server at 'unix:path=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/tests/test-home/.config/pulse/dbus-socket': Could not connect: No such file or directory

This seems related to (2). So when 2 get fixed 3 will get fixed as well.

See full build log here: https://launchpadlibrarian.net/416093469/buildlog_ubuntu-disco-amd64.indicator-sound_12.10.2+18.10.20180612-0ubuntu1+201903220811~ubuntu19.04.1_BUILDING.txt.gz

from ayatana-indicator-sound.

sunweaver avatar sunweaver commented on July 20, 2024

from ayatana-indicator-sound.

sunweaver avatar sunweaver commented on July 20, 2024

from ayatana-indicator-sound.

khurshid-alam avatar khurshid-alam commented on July 20, 2024

@sunweaver

please don't mix up ayatana-indicator-sound and indicator-sound. The
indicator-sound is the original project by Canonical, not so much
maintained anymore and Ubuntu-specific in its code base.

Hi Mike,

I am not mixing up at all. In Ubuntu 19.04 there is FTBFS for ayatana-indicator-sound. Does it compile in sid ? I will propose a merge if I find a way to fix those tests. Also it requires fix against vala >= 44

from ayatana-indicator-sound.

sunweaver avatar sunweaver commented on July 20, 2024

from ayatana-indicator-sound.

zippy-zebu avatar zippy-zebu commented on July 20, 2024

Same here, volume menu doesn't do anything.

And also it doesn't compile with latest glib. (Sid still has 2.58.3)

from ayatana-indicator-sound.

sunweaver avatar sunweaver commented on July 20, 2024

from ayatana-indicator-sound.

tari01 avatar tari01 commented on July 20, 2024

I am closing this because the problem is really in ayatana-ido not being able to build custom GMenu items.

from ayatana-indicator-sound.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.