Video not resized after class change about locomote-video-player HOT 9 CLOSED

The stage is listening to changes in the flash element and should resize the video accordingly, see: https://github.com/AxisCommunications/locomote-video-player/blob/master/src/Player.as#L111-L113

I'm a little confused as to why it doesn't resize for you. Which version of locomote are you using? This should be available in 0.1.0.

from locomote-video-player.

I think I was using an old one, because I updated to the one the master branch and I works more or less.

Now the behaviour is a bit different. The camera stream always takes the full size of the player and ignore the ratio of the stream. See screenshot below. I just added the camera on the right. Again if I go fullscreen and back, the size is back to normal.

Alternatively, I can use the videoResize() method that I just exposed in my pull request when the stream start (onstreamStarted) and everything is back to normal. Maybe you invoke the videoResize too fast and didn't wait for the stream to be available.

If you fixed it, you can ignore my pull request #98.

Regards

Gaétan

from locomote-video-player.

Locomote always take aspect ratio into account (see: https://github.com/AxisCommunications/locomote-video-player/blob/master/src/Player.as#L153-L172).

Could you provide an SSCCE which demonstrate the behavior you see above?

from locomote-video-player.

I don't have the time today, but I will try to reproduce this in a small example.

from locomote-video-player.

Luckily I reproduce this bug in a small example. It seems to be linked to CSS and not angular.

https://mega.co.nz/#!SgZBXSZY!lUiBsSncfrBiX_Au7qFtRXRK7FHIl0g3vkCsQG8u5x4

Use the parameter url to se the stream url (cf Readme).

Again, if you go fullscreen and back, the player size is ok.

from locomote-video-player.

Thanks. I'll see if I can reproduce and hopefully narrow down why the event is not transmitted as it should·

from locomote-video-player.

I managed to reproduce this (I think) and it was an issue when the new metadata (e.g. the video dimensions) was set and when resize was called. I think b044a8a should fix it. Would you mind testing if it works? It is available on master

from locomote-video-player.

Wow ! Not only you solve the bug but the player is much more reactive now !

Before, when you played a stream and you switched to another stream the first one was still displayed for some seconds (just a freeze on the last image). Now the new stream is directly played without freeze or anything.

Maybe it's due to another commit but nice work anyway ! 👍

from locomote-video-player.

I'm glad to hear it. I'm not sure why you're experiencing better responsiveness from the player though.. Might be that the resizing somehow makes it look and feel better.

from locomote-video-player.