Add s3-file-connector information to user-agent header about mountpoint-s3 HOT 6 CLOSED

Agreed! In particular, what we should be looking for here is for the s3_client crate to set a default user-agent for all its requests, and also allow the constructor of an S3Client to prepend whatever they want. Then the file connector can just set that config.

from mountpoint-s3.

We should also add versioning to that header.

from mountpoint-s3.

I think we should explicitly call this out as "S3 File Connector" (or whichever name we come up with). Of course, we can allow it to be prefixed too - but let's keep the name of the connector in there by default.

So default:

S3FileConnector/1.0 aws-s3-crt-rust/2.0 Linux/5.x

And with configurable prefix:

whateveriwant S3FileConnector/1.0 aws-s3-crt-rust/2.0 Linux/5.x

from mountpoint-s3.

Agreed! In particular, what we should be looking for here is for the s3_client crate to set a default user-agent for all its requests, and also allow the constructor of an S3Client to prepend whatever they want. Then the file connector can just set that config.

Re-reading this, this sounds exactly right.

Wasn't clicking the first time I read this thread when I responded earlier.
We don't need to provide a configurable user agent prefix for the file connector at this time - only in the S3 Client crate which we will use within the connector.

from mountpoint-s3.

We already do this: https://github.com/awslabs/s3-file-connector/blob/b671df4a0d8552804b45aca1af37eda7df44e024/s3-client/src/s3_client.rs#L137

But we should make it extensible so we can distinguish the connector from anyone else who ends up using this Rust S3 client.

from mountpoint-s3.

I think this would be a good first issue for @sauraank or myself to pickup.

from mountpoint-s3.