Git Product home page Git Product logo

Comments (3)

hhkkxxx133 avatar hhkkxxx133 commented on August 22, 2024

Hello,

Thanks for reporting this to us! We will test and remove if not used.

Thanks!

from aws-glue-schema-registry.

mohitpali avatar mohitpali commented on August 22, 2024

Constructor passes the configs to AbstractConfig that parses configurations from properties file.

from aws-glue-schema-registry.

jherico avatar jherico commented on August 22, 2024

@mohitpali I don't follow. Even if the AWSKafkaAvroConverterConfig ctor has a side effect which is important, why is an instance of the class being stored in AWSKafkaAvroConverter? If you removed the member and changed the code from awsKafkaAvroConverterConfig = new AWSKafkaAvroConverterConfig(configs); to new AWSKafkaAvroConverterConfig(configs); it would be functionally identical.

The member variable is

  • private
  • assigned but never read

That's a code smell and any decent Java linter will issue a warning about it.

from aws-glue-schema-registry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.