Git Product home page Git Product logo

Comments (2)

ChoiByungWook avatar ChoiByungWook commented on June 10, 2024

@ericangelokim,

What do you recommend?

I think when this was written it was to mimc this line in the SageMaker containers SDK functionality: https://github.com/aws/sagemaker-containers/blob/master/src/sagemaker_containers/_worker.py#L196

Can you reference an issue as an example?

Feel free to ping me if it is private.

Thanks!

from sagemaker-inference-toolkit.

ericangelokim avatar ericangelokim commented on June 10, 2024

I think you need to relinquish this validation to the customer. For example (personal case), this line fails if another encoding is sent but the customer sets content_type to be CSV. There isn't a good way to respond to the client with the root cause of the error.

I am working on another PR that adds error handling back to client, so we can work on that first and see if this situation changes.

from sagemaker-inference-toolkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.