Comments (4)
Thanks for the note - can you provide some more detail? I think the principle we are following here is "be liberal in what you accept" ... which should promote interoperability. I believe in general the version number in the record layer isn't particularly meaningful and I've seen proposals to "fix" it to 0x03 0x01 .. for the benefit of some implementations that were overly restrictive.
What behavior would you prefer to see?
from s2n-tls.
Looks like we're honoring the version number now. https://github.com/awslabs/s2n/blob/master/tls/s2n_record_read.c#L75 ?
from s2n-tls.
Looks like we also had a bug in the Record Layer Version number we were writing in the Client Hello: #418.
This issue is the reason that the client side bug went undetected for so long, our server code was liberal in what it accepted, so we didn't notice that we introduced a bug in the client side.
from s2n-tls.
Specifically, the RFC states:
Earlier versions of the TLS specification were not fully clear on what the record layer version number (TLSPlaintext.version) should contain when sending ClientHello (i.e., before it is known which version of the protocol will be employed). Thus, TLS servers compliant with this specification MUST accept any value {03,XX} as the record layer version number for ClientHello.
TLS clients that wish to negotiate with older servers MAY send any value {03,XX} as the record layer version number. Typical values would be {03,00}, the lowest version number supported by the client, and the value of ClientHello.client_version. No single value will guarantee interoperability with all old servers, but this is a complex topic beyond the scope of this document.
So this looks like s2n is following the RFC by accepting any Record Layer version up until conn->actual_protocol_version_established
is set. Once it is set, we enforce that the Record Layer Protocol Version matches the Actual Version Established.
from s2n-tls.
Related Issues (20)
- Integ test bloat
- Make S2N_CERT_AUTH_OPTIONAL the default for clients
- Support loading DER-encoded certificates and private keys
- consider adding a default negotiate timeout
- enforce result checking for s2n_stuffer methods
- Unpin dependencies after bumping MSRV beyond 1.70
- add visible debugging information for CI runs
- old libfuzzer used in CI
- old cppcheck used in CI
- Add schannel to integration tests HOT 1
- docs: Rust bindings need an explanation for Send/Sync impls HOT 1
- Add rustls to integration tests HOT 3
- test: SSLv2 integ test
- s2n_tls13_cert_verify_test doesn't run all cases HOT 1
- certificate_signature_preferences field contains unnecessary information HOT 2
- UBSAN triggers on `is_available` getting passed an incorrect function type HOT 5
- version 1.4.5: s2n_shutdown_test fail HOT 2
- clang format all .c and .h files
- make it easier to evaluate the impacts of changing security policies
- Clarify return values of IO APIs in the API documentation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s2n-tls.