Fails to build from source on prerelease Ubuntu, GCC about s2n-tls HOT 6 CLOSED

Hey thanks for reaching out. I don't think we want to completely unset the variable but instead should only set it if it hasn't already been defined. I can get a PR out to try and address that.

from s2n-tls.

It is fixed for me on your tree.

from s2n-tls.

It appears that a solution might be:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 5713558d3..55d33a548 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -176,6 +176,7 @@ target_compile_options(${PROJECT_NAME} PUBLIC -fPIC)

 add_definitions(-D_POSIX_C_SOURCE=200809L)
 if(CMAKE_BUILD_TYPE MATCHES Release)
+    add_definitions(-U_FORTIFY_SOURCE)
     add_definitions(-D_FORTIFY_SOURCE=2)
 endif()

from s2n-tls.

I've opened #4465, which should address the issue. Just need to work through the OpenBSD failure before merging it. If you want to try out my branch to confirm it fixes what you're seeing, that would also be helpful 😃

from s2n-tls.

Hi @jwbee, I've executed the ubuntu quickstart instructions on a Ubuntu 24.04 instance and have been unsuccessful in reproducing this issue so far. I've tried using GCC 12 and 13, and both succeeded. I wonder if the behavior could have changed since the prerelease. Are you still running into this issue with the final 24.04 release?

from s2n-tls.

You're right, it builds and tests on the release ubuntu, from main branch.

from s2n-tls.