Git Product home page Git Product logo

Comments (1)

bwagner5 avatar bwagner5 commented on July 17, 2024

I think it would be great if we could reuse https://github.com/aws/aws-node-termination-handler, no need in reinventing the wheel here.

As far as how it would integrate is something up for debate.

  1. NTH already handles events via EventBridge to SQS, so we could add a karpenter event that causes NTH to drain a node. NTH could even be configured to send a webhook to karpenter when it's complete for the node deletion. This would be the easiest, since all the functionality exists to do this today.
  2. Functionality could be added to NTH to make it more like a proper k8s controller. Karpenter could then mark nodes as needing to be drained, NTH would see nodes tainted or labeled a certain way (or monitor the Node CRDs), drain them, and then remove the label - something like that... This seems more extensible for other termination handler components to be plugged in later if necessary.
  3. Karpenter could call NTH directly via some registered http handler... this option doesn't seem great, but could work.

from karpenter-provider-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.