Route53 requests don't include a body about aws-sdk-go HOT 22 CLOSED

Yeah, it looks like a bug.

from aws-sdk-go.

I don't have a good Route53 use case or much time to work on this, but I'd absolutely accept a PR for this. It looks, in general, like the input shape for ChangeResourceRecordSets doesn't have payload set, which means the current template skips it. Not all requests should be serialized into request entities, so I'm not sure how to disambiguate. Perhaps you can.

from aws-sdk-go.

Let's track the debugging over here, @dgouldin. That last change should do it?

from aws-sdk-go.

Almost, except now you're emitting container elements for empty slices:

<ResourceRecords></ResourceRecords>

from aws-sdk-go.

How about now?

from aws-sdk-go.

Um, looks like I lost <EvaluateTargetHealth>false</EvaluateTargetHealth> with that commit.

from aws-sdk-go.

Did you set that using aws.False or aws.Boolean? It should only skip that if the value is nil.

from aws-sdk-go.

aws.Boolean(false). It was there before that last commit. Let me try using aws.False instead ...

from aws-sdk-go.

Yeah, same. It's still missing with aws.False.

from aws-sdk-go.

This looks like an inconsistency w/ encoding/xml: http://play.golang.org/p/4pOo8Knh8c

from aws-sdk-go.

Yep: golang/go#5452

Not sure what to do w/ this.

from aws-sdk-go.

There's no way to explicitly specify that EvaluateTargetHealth has to always be included is there?

from aws-sdk-go.

Ideally, the pointer serves as that sigil, but that doesn't work with encoding/json.

We can either encode everything or skip all zero values.

from aws-sdk-go.

d3f7b74 should restore manual control, at least, but it won't be satisfactory until the underlying bug in encoding/json is fixed.

from aws-sdk-go.

Sorry if I'm being dense. <EvaluateTargetHealth>false</EvaluateTargetHealth> is back but so is <ResourceRecords></ResourceRecords>. Is there something I need to do to get this working?

from aws-sdk-go.

ResourceRecords has omitempty set, so it shouldn't be marshaling empty slices.

I'm tracking the XML zero value issue over at #32, but it's mostly awkward staring at stdlib bugs.

from aws-sdk-go.

I might have a fix: https://github.com/stripe/aws-go/tree/xml-zero-value-kludge

Would you give that a try? I think it should line up with expectations.

from aws-sdk-go.

Looks like both EvaluateTargetHealth and ResourceRecords render as I would expect when using that branch. Oddly, though, now we have a mystery element <->...</-> whose contents are the HostedZoneID used in the uri path:

<ChangeResourceRecordSetsRequest xmlns="https://route53.amazonaws.com/doc/2013-04-01/">
    <ChangeBatch>
        <Change>
            <Action>CREATE</Action>
            <ResourceRecordSet>
                <AliasTarget>
                    <DNSName>{elb.DNSName}</DNSName>
                    <EvaluateTargetHealth>false</EvaluateTargetHealth>
                    <HostedZoneId>{elb.HostedZoneID}</HostedZoneId>
                </AliasTarget>
                <Name>{hostname}</Name>
                <Type>A</Type>
            </ResourceRecordSet>
        </Change>
    </ChangeBatch>
    <->{hostedZoneID}</->
</ChangeResourceRecordSetsRequest>

This wasn't happening in previous commits.

from aws-sdk-go.

Pushed a fix for that—I hadn't re-implented the bit where it skips elements named -. Try again?

from aws-sdk-go.

Ah, noticed one more regression: good ole <Changes> between <ChangeBatch> and <Change>. 😦

from aws-sdk-go.

Fixed. Maybe now?

Coda Hale
[email protected]

On Dec 20, 2014, at 2:12 PM, David Gouldin [email protected] wrote:

Ah, noticed one more regression: good ole between and .

—
Reply to this email directly or view it on GitHub #30 (comment).

from aws-sdk-go.

🔔 🔔 🔔 we have a winner!

from aws-sdk-go.