Comments (6)
@cogwirrel Agree that props.repositoryName
prefix seems like a good solution, and creates a deterministic export name. Are there other exports we should consider prefixing while we are in there? Since all exports must be unique, best to always prefix to don't block other stacks
from aws-pdk.
Just had a quick look and yes, we should also prefix SonarqubeSecretArn
https://github.com/aws/aws-prototyping-sdk/blob/5a2afcb075b20ca2980dc74d81e271adb38d52ec/packages/pipeline/src/code_scanner/sonar-code-scanner.ts#L227-L230
For this one we'll have to make sure our internal tool points to the new export name as we automate writing the sonar qube token to that secret :)
from aws-pdk.
This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.
from aws-pdk.
Why is this even an export and not simply an output? I can't find anything that imports the value. I searched all of GitHub for CodeRepositoryGRCUrl
, and the only results are the export and test snapshots.
If we make this a simple output, it will solve this problem.
from aws-pdk.
I see examples of SonarqubeSecretArn
getting imported but only in the aws-sample that was based on, so there's still a question of whether that needs to be exported.
How are developers using these values?
from aws-pdk.
The sonar qube secret export is used by our internal tool for bootstrapping new prototyping projects :) I'll send you a link!
As far as I know the code repo url is exported just so it's printed after a CDK deploy, so that users know what to put in the git remote add
command :)
from aws-pdk.
Related Issues (20)
- [BUG] projen generates inconsistent path separator for windows users HOT 4
- [BUG] sharp issue for new pdk project HOT 1
- [DOCS] update docs to reflect BUN support HOT 1
- [BUG] (cannot create new monorepo-py) HOT 1
- [BUG] graph plugin does not respect per-diagram FilterPlan config HOT 1
- test
- [FEATURE] test
- [FEATURE] (short issue description)
- [BUG] Upgrade Deps issues HOT 5
- [BUG] CDK deployment fails due to missing modules HOT 2
- [BUG] aenum based unit tests seem broken HOT 4
- [DOCS] Inconsistent monorepo const name HOT 3
- [BUG] Issue with CloudscapeReactTsWebsiteProject package name with InfrastructureTsProject HOT 2
- [BUG] unmet peer projen@^0.76.25: found 0.77.3 HOT 3
- [BUG] [type-safe-api] Error: Path /path contains unsupported methods summary, description, parameters. Supported methods are get, put, post, delete, options, head, patch, trace. HOT 2
- [DOCS] Add Windows/WSL onboarding to Getting Started Page HOT 1
- [BUG] Python pdk command "Cannot find module '../lib/cli.js'" HOT 2
- [BUG] Current stable python version (3.11) requires an explicit installation of 3.11 dependencies in .projenrc
- [FEATURE] (type-safe-api) Ability to configure runtime/language versions in one place
- [BUG] (monorepo) upgrade-deps using outdated syncpack (error) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-pdk.