optionalDependencies are still added to node_modules about aws-lambda-builders HOT 5 CLOSED

Hello @jchirschy,

I am not able to reproduce your issue with following code:

package.json

{
  "name": "hello_world",
  "version": "1.0.0",
  "main": "app.js",
  "dependencies": {
    "axios": "^0.18.0"
  },
  "scripts": {
    "test": "mocha tests/unit/"
  },
  "optionalDependencies": {
    "jshint": "2.10.3"
  },
  "devDependencies": {
    "chai": "^4.2.0",
    "mocha": "^6.1.4"
  }
}

node_modules folder

$ /bin/ls .aws-sam/build/HelloWorldFunction/node_modules
axios			concat-map		fs.realpath		is-buffer		ms			wrappy
balanced-match		debug			inflight		lodash			once
brace-expansion		follow-redirects	inherits		minimatch		path-is-absolute

As you can see optionalDependency jshint is missing from node_modules folder.

I am using npm 6.9.0 with node 10.16.3. Can you please share more details about what you are seeing and what you expect?

Thanks
Tarun

from aws-lambda-builders.

Hello @c2tarun,

Thanks for your help.
Have you tried with optionalDependencies only ?
I typically use Lambda layers 'linked' to AWS lambda functions where there is no node_modules folder necessary for the Lambda functions.

from aws-lambda-builders.

Hello,

I confirm that optional dependencies are still added with the following configuration :

• Node v12.18.2
• SAM CLI, version 1.2.0

It works fine with :

• Node v8.9.4
• SAM CLI, version 1.2.0

Any idea ?

from aws-lambda-builders.

Please pay attention to your NPM versions.
While optional=false is expected to work with NPM 6, it was removed in NPM 7 where you should use omit=optional instead.
See https://docs.npmjs.com/cli/v7/using-npm/config#omit

from aws-lambda-builders.

Thank you @projected1 for sharing the info.
@jchirschy please open a new issue if you still encounter the issue. Closing due to unable to reproduce it and it is too outdated.

from aws-lambda-builders.