Comments (11)
RedbackThomson
commented on May 30, 2024
1
Hi William
Our operator container attempts to reconcile every type of CRD within just the one image. Therefore, I believe it might be a requirement to have each of them installed on the cluster for that to work. We have not attempted to install only a subset, so I would have to double check that.
What part of the deployment is causing you issues? I believe we reference all CRDs as part of the master ServiceAccount for the operator, at least.
Also, is this repo properly packaged to be installed as a go module
Yes! We have included all the autogen files as part of the repository, so it should be ready to be consumed as a go module. If you have any issues with this, please reach out to us.
from amazon-sagemaker-operator-for-k8s.
song-william
commented on May 30, 2024
On the go module issue, when I run go get github.com/aws/amazon-sagemaker-operator-for-k8s, I get the following error message:
# k8s.io/client-go/tools/clientcmd/api/v1
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:29:15: scheme.AddConversionFuncs undefined (type *runtime.Scheme has no field or method AddConversionFuncs)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:31:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:34:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:37:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:40:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:43:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:46:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:49:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
../../../../pkg/mod/k8s.io/[email protected]+incompatible/tools/clientcmd/api/v1/conversion.go:52:12: s.DefaultConvert undefined (type conversion.Scope has no field or method DefaultConvert)
# github.com/aws/amazon-sagemaker-operator-for-k8s/api/v1/common
../../../../pkg/mod/github.com/aws/[email protected]/api/v1/common/manual_deepcopy.go:28:19: tag.DeepCopy undefined (type Tag has no field or method DeepCopy)
# k8s.io/client-go/rest
../../../../pkg/mod/k8s.io/[email protected]+incompatible/rest/request.go:598:31: not enough arguments in call to watch.NewStreamWatcher
have (*versioned.Decoder)
want (watch.Decoder, watch.Reporter)
# k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1
../../../../pkg/mod/k8s.io/[email protected]/pkg/apis/apiextensions/v1beta1/conversion.go:29:15: scheme.AddConversionFuncs undefined (type *runtime.Scheme has no field or method AddConversionFuncs)
from amazon-sagemaker-operator-for-k8s.
song-william
commented on May 30, 2024
The deployment fails to start up with the following error when I do not have the other CRDs declared:
2020-05-15T03:14:25.756Z ERROR controller-runtime.source if kind is a CRD, it should be installed before calling Start {"kind": "HyperparameterTuningJob.sagemaker.aws.amazon.com", "error": "no matches for kind \"HyperparameterTuningJob\" in version \"sagemaker.aws.amazon.com/v1\""}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/source/source.go:88
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Watch
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122
sigs.k8s.io/controller-runtime/pkg/builder.(*Builder).doWatch
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/builder/controller.go:162
sigs.k8s.io/controller-runtime/pkg/builder.(*Builder).Build
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/builder/controller.go:151
sigs.k8s.io/controller-runtime/pkg/builder.(*Builder).Complete
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/builder/controller.go:129
github.com/aws/amazon-sagemaker-operator-for-k8s/controllers/hyperparametertuningjob.(*Reconciler).SetupWithManager
/workspace/controllers/hyperparametertuningjob/hyperparametertuningjob_controller.go:357
main.main
/workspace/main.go:93
runtime.main
/usr/local/go/src/runtime/proc.go:203
2020-05-15T03:14:25.756Z ERROR setup unable to create controller {"controller": "HyperparameterTuningJobReconciler", "error": "no matches for kind \"HyperparameterTuningJob\" in version \"sagemaker.aws.amazon.com/v1\""}
github.com/go-logr/zapr.(*zapLogger).Error
/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
main.main
/workspace/main.go:95
runtime.main
/usr/local/go/src/runtime/proc.go:203
I think we can just go ahead install the other CRDs to unblock us. I was just wondering if there was a way to disable the controllers for different CRDS with a flag argument or something similar.
from amazon-sagemaker-operator-for-k8s.
RedbackThomson
commented on May 30, 2024
I think we can just go ahead install the other CRDs to unblock us. I was just wondering if there was a way to disable the controllers for different CRDS with a flag argument or something similar.
Unfortunately at the moment we do not have this functionality, no.
from amazon-sagemaker-operator-for-k8s.
RedbackThomson
commented on May 30, 2024
On the
go moduleissue, when I rungo get github.com/aws/amazon-sagemaker-operator-for-k8s, I get the following error message:
Ah, yes I remember seeing this error before. We only included the autogen files when we updated master, but have not backported those files into the release branches. These should be included in future release branches, but for the moment I would recommend instead of pinning your go module to using v1.1.0 that you pin it to master branch instead.
from amazon-sagemaker-operator-for-k8s.
song-william
commented on May 30, 2024
@RedbackThomson, is there a public slack or other messaging group that I may join for these types of discussions. I couldn't find anything in CONTRIBUTING.md besides [email protected]. Would love to potentially contribute!
from amazon-sagemaker-operator-for-k8s.
awcchungster
commented on May 30, 2024
@song-william We don't have a slack yet, but we definitely want to help you. Do you know who your AWS account manager is? If you can reach out to them, we can start a direct thread to streamline collaboration.
from amazon-sagemaker-operator-for-k8s.
song-william
commented on May 30, 2024
Ah, yes I remember seeing this error before. We only included the autogen files when we updated master, but have not backported those files into the release branches. These should be included in future release branches, but for the moment I would recommend instead of pinning your go module to using v1.1.0 that you pin it to master branch instead.
@RedbackThomson I run into the same error message when running go get github.com/aws/amazon-sagemaker-operator-for-k8s@master to pin the version to master.
from amazon-sagemaker-operator-for-k8s.
RedbackThomson
commented on May 30, 2024
What about plainly go get github.com/aws/amazon-sagemaker-operator-for-k8s ? I don't seem to be able to recreate any errors
from amazon-sagemaker-operator-for-k8s.
RedbackThomson
commented on May 30, 2024
@song-william I have backported the generated files to the r1.1 branch, alongside this I moved the release tag up to this latest commit. Would you mind trying to go get the default release and see if that works now?
from amazon-sagemaker-operator-for-k8s.
song-william
commented on May 30, 2024
It turns out that the a lot of the error messages I had posted previously were due to some indirect dependency issues in my current repo. If I run go get github.com/aws/amazon-sagemaker-operator-for-k8s in a new, clean repo (after cleaning my cache with go clean -modcache) I still get the following error:
# github.com/aws/amazon-sagemaker-operator-for-k8s/api/v1/common
../../../../pkg/mod/github.com/aws/[email protected]/api/v1/common/manual_deepcopy.go:28:19: tag.DeepCopy undefined (type Tag has no field or method DeepCopy)
However, pinning the version to master (go get github.com/aws/amazon-sagemaker-operator-for-k8s@master) has no issues, so I can just use the master pin.
from amazon-sagemaker-operator-for-k8s.
Related Issues (20)
- On-premise K8S cluster integrated with Sagmaker operator HOT 2
- Error Building SageMaker Types due to missing types in common/manual_deepcopy HOT 1
- Why blocking HPOJobs with "not having enough combinations of hyperparameter ranges"? HOT 4
- SageMaker Operator Types fails KubeBuilder Pattern validation check HOT 2
- AccessDenied issue HOT 2
- how to use amazon-sagemaker-operator-for-k8s in ec2 k8s like Minikube HOT 4
- How can i pass endpointName & custom container env variables on HostingDeployment ? HOT 2
- Establish a regular release cadence? HOT 1
- Upgrade aws-sdk to v1 HOT 2
- KmsKeyId will constantly reconcile if not using ARN HOT 1
- error: no kind "TrainingJob" is registered for version "sagemaker.aws.amazon.com/v1" in scheme "k8s.io/kubectl/pkg/scheme/scheme.go:28" HOT 3
- error: no kind "TrainingJob" is registered for version "sagemaker.aws.amazon.com/v1" in scheme "k8s.io/kubectl/pkg/scheme/scheme.go:28" HOT 1
- Error reconciling customizedMetricSpecification HostingAutoscalingPolicy HOT 6
- Improve HAP logging message HOT 1
- Add checksum file to enable the installation of the chart from helm HOT 1
- StepScaling policy support HOT 1
- Submitted TrainingJob won't invoke SageMaker HOT 3
- README.md broken link HOT 1
- Async Endpoint Request HOT 1
- Migrating to v1 as v1beta is deprecated HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-sagemaker-operator-for-k8s.