Git Product home page Git Product logo

Comments (4)

bwagner5 avatar bwagner5 commented on May 24, 2024

The EMR service integration is not the best tbh. To my knowledge there is no API to determine which instance types are supported for EMR, just the docs page which is pretty difficult to read. It may be worth deprecating the EMR service integration.

Here's the current logic: https://github.com/aws/amazon-ec2-instance-selector/blob/main/pkg/selector/emr.go

from amazon-ec2-instance-selector.

chrismld avatar chrismld commented on May 24, 2024

@bwagner5 thanks for the feedback, I thought it was a parameter being forwarded to the API but I see the list is hard coded. So, in the meantime, should we exclude types that are not supported as we get feedback?

from amazon-ec2-instance-selector.

bwagner5 avatar bwagner5 commented on May 24, 2024

We can do that. Are you able to submit a PR with more accurate instance types list per version?

from amazon-ec2-instance-selector.

chrismld avatar chrismld commented on May 24, 2024

@bwagner5 sure, I'll work on updating the instance types for EMR

from amazon-ec2-instance-selector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.