Improve clarity and fix Docs for Logging about powertools-lambda-java HOT 12 CLOSED

I don't think it's possible to get the alias from the context - https://docs.aws.amazon.com/lambda/latest/dg/java-context.html
Do you have any other suggestions?

from powertools-lambda-java.

from powertools-lambda-java.

For sure. Thank you all!

from powertools-lambda-java.

I think service_undefined works well here, it matches the python implementation and gives us a service name to use when we implement Metrics. We'll need a reasonable default for that core util as well.

from powertools-lambda-java.

For sampling, I'm happy with the String / Double approach. If this was a public method I think it would be best as a unit. But because it's an environment variable I think it would only increase complexity.

from powertools-lambda-java.

I think service_undefined works well here, it matches the python implementation and gives us a service name to use when we implement Metrics. We'll need a reasonable default for that core util as well.

This is misleading, if we don't know the name, I would assume that is better to default to the FunctionName or even FunctionName:Version, until the customer properly configures it.

I don't think it's possible to get the alias from the context - https://docs.aws.amazon.com/lambda/latest/dg/java-context.html
Do you have any other suggestions?

getInvokedFunctionArn() – Returns the Amazon Resource Name (ARN) that's used to invoke the function. Indicates if the invoker specified a version number or alias.

For sampling, I'm happy with the String / Double approach. If this was a public method I think it would be best as a unit. But because it's an environment variable I think it would only increase complexity.

I think the point here is readability, if the argument is called samplingRate, I have to lookup/assume which is the actual unit, but this is totally style. Hopefully we have more inputs here.

from powertools-lambda-java.

W.r.t - service_undefined provides an opportunity for the customer to fix it. Service has also a deeper meaning as it acts as a namespace when looking for data across multiple functions be that logs, metrics or traces.

As to context, I don't know about Java, but in the Python context object it'll fetch a FQDN -- If it's a given published version or alias it'll be the last value <function_name>:<version_or_alias>

from powertools-lambda-java.

I'd be really happy to look at a PR for adding alias information.

from powertools-lambda-java.

W.r.t - service_undefined provides an opportunity for the customer to fix it. Service has also a deeper meaning as it acts as a namespace when looking for data across multiple functions be that logs, metrics or traces.

100%, but as soon as a customer incorporates that into multiple functions they will see service_undefined in multiple logstreams, or am I missing something? This goes hand-in-hand with tracing span naming which I'm in full agreement.

Now for the Alias, I'm seeking guidance on whether there's any logic behind or simply callee information.

from powertools-lambda-java.

Alias as part of the context was something discussed in the aws-lambda-java-libs project.

aws/aws-lambda-java-libs#10

You might want to continue the discussion there.

from powertools-lambda-java.

Message, Unserializable JSON values will be casted to string, question: How? calling toString()? if so, tell that toString() will be called. Also, what about exceptions there? Will that be swollen?

This should be fixed as part of #113

from powertools-lambda-java.

@dgomesbr Can this issue be closed now based on some of the discussions above? 🤔

from powertools-lambda-java.