Git Product home page Git Product logo

Comments (13)

michaelbrewer avatar michaelbrewer commented on September 26, 2024 2

@pankajagrawal16 @msailes - i have created a PR to potentially fix the gradle plugin used for AspectJ

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024 1

@pankajagrawal16 still not working for me? Could we try https://docs.freefair.io/gradle-plugins/5.0.1/reference/#_aspectj instead?

Hey, this is the plugin which I was going to look into, but i am not working this week, so will check once back.

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024 1

@michaelbrewer It works with freefair gradle plugin. I have validated it and change is pretty simple. Would you mind validating it as well ? I am thinking we can officially update our docs to used free fair instead coz it seems to be actively maintained and works on gradle 5,6 and 7 as well

from powertools-lambda-java.

michaelbrewer avatar michaelbrewer commented on September 26, 2024 1

@pankajagrawal16 - FYI my PR for aspectj.AspectjGradlePlugin was merged

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024 1

woho.. nice.. then probably we have two ways of configuring gradle project. I am still in favor of keeping freefair now since its much more active.

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024

Latest version 0.0.6 of AspectjGradlePlugin works with Java 11 and Gradle 6.x.

Unfortunately it wont be supported for Java 8 since java 11 is the current LTS version. Ref issue

from powertools-lambda-java.

michaelbrewer avatar michaelbrewer commented on September 26, 2024

And it does not work at all with Gradle 7+

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024

And it does not work at all with Gradle 7+

Yeah I need to dive a bit deeper into this and see how we can get it to work with gradle 7+

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024

All gradle 5 and 6 related issues should now be fixed with using latest version of AspectGradlePlugin with version 0.0.7 https://github.com/awslabs/aws-lambda-powertools-java/releases/tag/v1.9.0

from powertools-lambda-java.

michaelbrewer avatar michaelbrewer commented on September 26, 2024

@pankajagrawal16 still not working for me? Could we try https://docs.freefair.io/gradle-plugins/5.0.1/reference/#_aspectj instead?

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024

This is what my sample build.gradle looks like for a sample hellp world gradle app via

sam init --location gh:aws-samples/cookiecutter-aws-sam-powertools-java

plugins{
    id 'java'

    id "io.freefair.aspectj.post-compile-weaving" version "5.0.1"
}

repositories {
    mavenCentral()
}

aspectj {
    version  = "1.9.7"
}

dependencies {
    aspect "software.amazon.lambda:powertools-logging:1.10.0"
    aspect 'software.amazon.lambda:powertools-tracing:1.10.0'
    aspect 'software.amazon.lambda:powertools-metrics:1.10.0'

    implementation 'com.amazonaws:aws-lambda-java-core:1.2.1'
    implementation 'com.amazonaws:aws-lambda-java-events:3.11.0'

    implementation 'org.apache.logging.log4j:log4j-api:2.17.0'
    implementation 'org.apache.logging.log4j:log4j-core:2.17.0'

    testImplementation 'junit:junit:4.13.2'
}

from powertools-lambda-java.

pankajagrawal16 avatar pankajagrawal16 commented on September 26, 2024

Docs and cookiecutter projects are now update to use the new config which should work for all gradle versions 5, 6 and 7.

cc @michaelbrewer Closing this now, Let me know if you face any issues.

from powertools-lambda-java.

michaelbrewer avatar michaelbrewer commented on September 26, 2024

Yep, i agree, when i tried freefair initially i could not verify locally it was working (only when deployed)

from powertools-lambda-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.