Git Product home page Git Product logo

Comments (7)

johnttompkins avatar johnttompkins commented on July 16, 2024 1

Looks like pre-commit natively supports rust as a buildable language plugin. If this is the case, this should be straightforward to offer.

from cloudformation-guard.

nathanataws avatar nathanataws commented on July 16, 2024

This is very reasonable ask. We're looking at integrations right now. We'll pull this into that discussion.

from cloudformation-guard.

benbridts avatar benbridts commented on July 16, 2024

There are still some hurdles (at least the last time I tried):

  • You need to have rust installed (not much to do about that, and you can install cfn-guard yourself and use the system "language")
  • pre-commit passes all matching files on one invocation (or at least does so by default). I couldn't get it to invoke cfn-guard multiple times (that's why I created #62 )

from cloudformation-guard.

barnesrobert avatar barnesrobert commented on July 16, 2024

+1 to this issue. Pre-commits are a vital way of remediating latent vulnerabilities before they're committed.

from cloudformation-guard.

kgrvamsi avatar kgrvamsi commented on July 16, 2024

Do we have any update on this Feature request to support pre-commit hooks?

from cloudformation-guard.

kgrvamsi avatar kgrvamsi commented on July 16, 2024

if the project already have a .pre-commit-confg.yaml i see the below config works

  - repo: local
    hooks:
      - id: cfn-guard
        name: Run Cfn Guard
        language: system
        entry: "cfn-guard validate -r ./cfn-rules/cloudformation/aws/ --data ./cdk.out/"
        pass_filenames: false
       

from cloudformation-guard.

joshfried-aws avatar joshfried-aws commented on July 16, 2024

Hi @kgrvamsi we do not have any updates here yet.

from cloudformation-guard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.