Git Product home page Git Product logo

Comments (2)

awolden avatar awolden commented on May 26, 2024

Hi @DavideDaniel, thanks for looking into this and submitting the PR. I looked at transpiling this when it was first made, but the major use case is for server-to-server communication. The library requires high numbers of calls to the same service to determine the health of the downstream server, as such it maintains a lot of long running state. In isomorphic land, steps should be taken to ensure the library doesn't make it into client code by using webpack define or some other method.

With that being said, there might be use-case where a client is making a large number of calls to downstream services, but even then I still wouldn't want to transpile this lib since it will primarily be running on the server and it will make production server logs that much harder to decipher.

from brakes.

DavideDaniel avatar DavideDaniel commented on May 26, 2024

Yep, I agree, this lib should be kept out of client code. The pr isn't necessary as the root problem turned out to be a piece of isomorphic code that was being pulled into client code... there is a use case for restricting extra calls from clients but there are also existing solutions for those, so we can close this unless you see any other reason not to.

from brakes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.