Comments (2)
Hi @DavideDaniel, thanks for looking into this and submitting the PR. I looked at transpiling this when it was first made, but the major use case is for server-to-server communication. The library requires high numbers of calls to the same service to determine the health of the downstream server, as such it maintains a lot of long running state. In isomorphic land, steps should be taken to ensure the library doesn't make it into client code by using webpack define or some other method.
With that being said, there might be use-case where a client is making a large number of calls to downstream services, but even then I still wouldn't want to transpile this lib since it will primarily be running on the server and it will make production server logs that much harder to decipher.
from brakes.
Yep, I agree, this lib should be kept out of client code. The pr isn't necessary as the root problem turned out to be a piece of isomorphic code that was being pulled into client code... there is a use case for restricting extra calls from clients but there are also existing solutions for those, so we can close this unless you see any other reason not to.
from brakes.
Related Issues (20)
- nvmrc is right? HOT 2
- Brakes modifies original error message
- Support decorator usage like in java HOT 1
- waitThreshold is too high by default HOT 1
- Update Options HOT 2
- Timing the statInterval based on bucketNum & bucketSpan HOT 2
- Do you want TypeScript types in this repo?
- Remove racist terminology
- GlobalStatsStream does not track all instances after update to Node v12.16.0 HOT 5
- Reported request count never goes down? HOT 4
- Slave circuits not working as per the examples HOT 1
- Single-arg fat arrow function breaks brakes HOT 2
- CircuitBrokenError is taking threshold as failure rate
- CPU growth HOT 6
- Adding isFailure function
- Fallbacks executions HOT 3
- Add isSuccess option?
- Runaway memory growth/CPU utilization HOT 1
- 2.6.0 breaks non-string errors HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brakes.