Payment backends should change Order status when processed about django-shop HOT 5 CLOSED

At least that is what the comments say...

from django-shop.

The reason that order is not completed in payment backend is because ThankYouView would not work otherwise (get_order_from_request returns last order that is NOT completed).

In my opinion order should be completed when customer pay for it (indeed even if he closes the browser on 3rd party backend without waiting to be redirected back to shop).

For this to work, I propose that get_finished_url method in payment api have order argument and that it redirects to thank_you_for_your_order urlname with order ID. ThankYouView could display processed order and empty the cart.

from django-shop.

Hmm.. I have a 'Pay on advance' backend that sets the status to CONFIRMED only. I always override the ThankYouView and teach it not to set any status. As you said, setting of the status should be done by payment backends only.

I do this because I want to give the admin the chance to set the status to CONFIRMED and then SHIPPED / COMPLETED manually in the backend once the payment has arrived on his bank account.

But you raised an interesting issue here that I was not aware of. I have another backend for 'Pay on delivery'. That backend does set the status to COMPLETED and indeed, this causes trouble in the ThankYouView because if a customer first buys something with Pay in advance and right after that starts another transfer with Pay on delivery the ThankYouView would indeed select the wrong order. Duh. Thank god that I don't need the order in my ThankYouView.

This is quite messy. We need a solution for this. Your suggestion sounds good but we need to make sure that customers cannot see order details of other customers by messing with the URL...

from django-shop.

+1 to this

from django-shop.

change order status in api was addressed in d3bad93

thankyouview showing incorrect order fixed in a3140f9 (maybe we should make a test for this)

from django-shop.