Unnecessary code duplication? about django-shop HOT 4 CLOSED

Hmmm... in item.update nothing really gets saved but on the item instance some values get changed and modifiers get applied. Which is a bit weird for an update method. Any reason we don't save/update what we compute here?

So when we select the items again (line 110) the update that happened in cart_object.update() should probably be lost, thus we need to call update again in order to return items that have modifiers applied.

from django-shop.

Subtotals, totals and modifier for cart items or cart are not persistent. Thats ok.

I would like to see cart items cached in cart object when cart object is updated to avoid calling cart items update method too often.

from django-shop.

I was thinking about the same, like a get_car_items() method on the cart object that returns self.cart_items and this will be set in the cart's update method... would you like to send a pull request?

from django-shop.

sure, I will

from django-shop.