Add a way to easily extends django-shop models about django-shop HOT 7 CLOSED

Of all things, I would have least expected people wanting to change the cart model :)

This makes some sense, even though I generally don't like using the django settings for this (even though I used this trick for the address model already).
Would a signal be suitable for this task instead, maybe?

from django-shop.

I don't think a signal is the right answer for my case but I could be wrong.

I'm currently checking the stock of a product in the clean method of the CartItem model for the need of my application.
Because there is no option to override default models I have to use the "add_to_class" method to inject my method in those models.

I certainly will have others use cases in the next few days.

Thank you for your quick answer ;)

from django-shop.

Alright, I think I'll use the same settings-based approach as I have for the addressmodel, with a new optional setting (something like SHOP_CART_MODEL or similar)

I will however not isolate the cart in its own django app this time, so you will have "my" Cart table lying around. Is that ok?

from django-shop.

ok for me.

Sorry for the delay.

from django-shop.

Fully agree, cart/order/.. models should be replacable through settings. We have powerfull python duck typing to do that.

from django-shop.

I have commited some changes that should fix this issue. Please see the relevant documentation, and reopen this ticket if it doesn't suit your needs somehow :)

from django-shop.

Neat, thank you for your time I will have to replace all my (bad) monkey patches with this approach now.

BTW, our presale service is powered by django-shop ;)

from django-shop.