Git Product home page Git Product logo

Comments (4)

simonluijk avatar simonluijk commented on July 22, 2024

I'm working on multi currency support. It will require an extra method on the API, "get_order_currency". I hope to have a general working solution in the next few weeks.

from django-shop.

chrisglass avatar chrisglass commented on July 22, 2024

I would be interested to know how you plan on implementing this.

I have given it a stab in https://github.com/chrisglass/django-shop-multiplecurrencies . While not elegant nor very practical, it has the advantage of not needing anything changed in the core API or models. I chose this approach because I wanted to keep backwards-compatibility as much as possible.

If you don't mind, it would be nice if you could publish a branch on github (even if clearly marked as "work in progress"), just so that we can see where you are going with this (and possibly help you out, too)

from django-shop.

chrisglass avatar chrisglass commented on July 22, 2024

Also, "get_order_currency" seemsto assume there is only one currency per Order ;)

from django-shop.

simonluijk avatar simonluijk commented on July 22, 2024

I am keeping as much as possible as a separate app, with a few change to core. So far all have been backwards compatible :)

I have taken a look at your app. The difficulty with muiti currency is that the currency is attached to the request for the cart-items and products. This is not available in get_price. I intend to push my development branch to github, hopefully some time this week. It won't be anywhere near a complete solution.

I can see how you could have OrderPayment, OrderItem objects in different currencies. But I think it would not be a unreasonable restriction to limit them and the Order to one currency. Cart items on the other hand change base on the request.

from django-shop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.