I am looking into adding a awesome-git package to Nix / nixpkgs, and it uses <code cla

Why do we have two places running "git describe" anyway` </blockquote

build: allow to pass in VERSION / GIT_VERSION about awesome HOT 2 CLOSED

awesomewm commented on May 19, 2024

build: allow to pass in VERSION / GIT_VERSION

from awesome.

Comments (2)

psychon commented on May 19, 2024

This is the relevant part of awesomeConfig.cmake:

# {{{ Version stamp
if(EXISTS ${SOURCE_DIR}/.git/HEAD AND GIT_EXECUTABLE)
    # get current version
    execute_process(
        COMMAND ${GIT_EXECUTABLE} describe --dirty
        WORKING_DIRECTORY ${SOURCE_DIR}
        OUTPUT_VARIABLE VERSION
        OUTPUT_STRIP_TRAILING_WHITESPACE)
    # file the git-version-stamp.sh script will look into
    set(VERSION_STAMP_FILE ${BUILD_DIR}/.version_stamp)
    file(WRITE ${VERSION_STAMP_FILE} ${VERSION})
    # create a version_stamp target later
    set(BUILD_FROM_GIT TRUE)
elseif( EXISTS ${SOURCE_DIR}/.version_stamp )
    # get version from version stamp
    file(READ ${SOURCE_DIR}/.version_stamp VERSION)
endif()
# }}}

The variable VERSION is already set to devel at the beginning of the file. So... Dunno. Introduce an OVERRIDE_VERSION variable which is only evaluated after this?

if(OVERRIDE_VERSION)
    set(VERSION ${OVERRIDE_VERSION})
endif()

I'm not fully convinced.

Edit: This would later be overwriten by the version_stamp target running build-utils/git-version-stamp.sh... Why do we have two places running "git describe" anyway` :-(

from awesome.