User ID bug in comments integration about edd-slack HOT 4 CLOSED

Huh, that's weird that it was running on Vendor Feedback. EDD Reviews does this weird thing were it avoids using comments properly so it shouldn't be firing there as far as I'm aware.

I'll make sure I patch this up though.

from edd-slack.

I have tried to replicate this with Reviews v2.0.4 and FES v2.4.2 active and when visiting /vendor-feedback which is a page that contains the [edd_reviews_vendor_feedback] shortcode it gives me the following screen. This is after purchasing a Vendor Product and I have tried this both as a Administrator and a Subscriber.

from edd-slack.

Looked more closely at the EDD Reviews source code and I realized that you need to click a link from your Purchase History page for the Vendor Feedback page to work. Going to investigate more closely.

Vendor Feedback would be a good Trigger to have, but that should require both Reviews and FES to be active and needs to be separate from regular Comments.

from edd-slack.

Something I didn't realize until just now, FES adds Comment Support to the Downloads Post Type. This was partly why this collision happened in the first place (I guess when the form is created, it isn't resetting global $post otherwise it should be a Page, not a Download). Since I haven't gotten around to making the Reviews triggers as part of #19 yet, I had not noticed something like this could happen.

Very good catch on Sean's part 👍

This fix as well as #47 and #48 are ready to go for an update if there's nothing else that has been reported.

from edd-slack.