Git Product home page Git Product logo

Comments (10)

johanhaleby avatar johanhaleby commented on May 18, 2024

Isn't it possible to combine given().ignoreException(..) with a ConditionEvaluationListener?

from awaitility.

TheNitek avatar TheNitek commented on May 18, 2024

I think I got it working by (mis-)using ignoreExceptionsMatching(...) with my logging code and return true, but it doesn't feel like good solution ...

from awaitility.

johanhaleby avatar johanhaleby commented on May 18, 2024

No that's not an optimal solution. But couldn't you use ignoreException* for ignoring the exception(s) and an ConditionEvaluationListener for logging purposes?

from awaitility.

TheNitek avatar TheNitek commented on May 18, 2024

But I cannot get the Exception information in the Listener, can I?

from awaitility.

johanhaleby avatar johanhaleby commented on May 18, 2024

Not atm, but perhaps it would be a good idea to add this? Would that solve your problem?

from awaitility.

TheNitek avatar TheNitek commented on May 18, 2024

Yes, that would be a good solution!

from awaitility.

grofoli avatar grofoli commented on May 18, 2024

@johanhaleby What do you think about this issue today (after more than two years)? If you think this is still a good a idea/meaningful feature, then I can probably tackle this. What solution would you prefer? Should I introduce a new method in the ConditionEvaluationListener like onException ?

from awaitility.

johanhaleby avatar johanhaleby commented on May 18, 2024

@grofoli That would be really helpful!

from awaitility.

grofoli avatar grofoli commented on May 18, 2024

@johanhaleby I hope you like the PR.

from awaitility.

erwinw avatar erwinw commented on May 18, 2024

@ johanhaleby I hope you like the PR.

Years later, but ... I really appreciate this API change (and the rest of the project!) -- thanks!

from awaitility.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.