Git Product home page Git Product logo

Comments (7)

aviaviavi avatar aviaviavi commented on June 1, 2024

@hvr thanks so much for taking the time to open this issue and for the thorough explanation! I'll fix these things shortly.

An aside - I recently put another executable on Hackage that has the same issues as toodles, so you've really helped multiple repo's with this comment.

from toodles.

hvr avatar hvr commented on June 1, 2024

@aviaviavi I'm afraid that lower bounds aren't enough, the build matrix is still red

But I notice you're using Stack which can generate/infer bounds from the stackage collection you used; e.g. you can add pvp-bounds: both to your stack.yaml file (which causes e.g. stack sdist to insert bounds where they're missing; see e.g. https://www.fpcomplete.com/blog/2015/09/stack-pvp )

Another tool is staversion (https://github.com/debug-ito/staversion) if you need more flexibility

(btw, are you aware of https://github.com/haskell-infra/hackage-trustees/blob/master/revisions-information.md ?)

from toodles.

aviaviavi avatar aviaviavi commented on June 1, 2024

@hvr ah these suggestions are very helpful, just what I was looking for! I had no idea what I was doing when trying to fix this, and my last package upload was mostly a shot in the dark. I'll try out these other approaches soon.

from toodles.

aviaviavi avatar aviaviavi commented on June 1, 2024

Also good to know one can change these bounds without uploading a new version, didn't know!

from toodles.

aviaviavi avatar aviaviavi commented on June 1, 2024

@hvr question for you - because this is just a binary distribution and not a library, in your opinion is there much harm in just pinning down most or all of the dependencies to exact versions?

from toodles.

aviaviavi avatar aviaviavi commented on June 1, 2024

Well, with pinning them down exactly, this is building properly with ghc-8.4. Open getting this to work with other versions too if that's straightforward to do given a working stack project? If it's too much of a headache I may put that off until I know that people actually want to use this tool :)

from toodles.

aviaviavi avatar aviaviavi commented on June 1, 2024

closing for now, now that this is cabal install-able, i'll make improvements to getting it to work with more versions now. feel free to re-open if there are other things to address.

thanks again @hvr !

from toodles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.