Side nav divider about adminthemebundle HOT 6 OPEN

@MartinLyne congratulations for your new pcntl_fork() for main thread life!!

$pid = pcntl_fork();
if ($pid == -1) {
     die('Oops some conception problem');
} else if ($pid) {
     // MartinLyne is the parent
     pcntl_wait($status); //Protect against Zombie children ;)
} else {
     // your new baby child life
}

When you can leave in safe thread your things, just return here again ;)

PS: Probably I will try follow and reproduce your issue/bug with fork() in some years. So all the feedback about the issue is welcome ;)

from adminthemebundle.

I don't know if there is one currently - at least nothing's documented. The best way to handle this would be to create a new type of MenuItem, don't you think?

from adminthemebundle.

@MartinLyne if have knowlegde, pull request are welcome to add the side nav divider, thanks

from adminthemebundle.

@MartinLyne @chteuchteu

Dividers are child elements, because that semantically best matches how dividers are represented in the HTML by Bootstrap.

Could you try with:

$menu->addChild('divider', ['divider' => true]);

For example:

$menu->addChild('item1');
$menu->addChild('item2');
$menu->addChild('divider', ['divider' => true]);
$menu->addChild('item3');
$menu->addChild('item3');

It should generate something like:

<li>item 1</li>
<li>item 2</li>
<li class="divider"></li>
<li>item 3</li>
<li>item 4</li>

If doesn't work, a way to implement this could be:

namespace AppBundle\Menu\Item;

use Knp\Menu\FactoryInterface;
use Knp\Menu\MenuItem;

final class DividerMenuItem extends MenuItem
{
    /**
     * @param FactoryInterface $factory
     */
    public function __construct(FactoryInterface $factory)
    {
        parent::__construct('divider', $factory);

        $this
            ->setExtra('divider', true)
            ->setAttribute('class', 'separator')
        ;
    }
}

Then, on your builder:

$menu->addChild(new DividerMenuItem($this->factory));

And on theme probable override something like:

{% block spanElement %}
    {% import 'knp_menu.html.twig' as knp_menu %}
    {% if not item.extra('divider') %} {% Don't show menu content if it's a divider %}
        <span>{{ knp_menu.attributes(item.labelAttributes) }}>
            {% if item.extra('icon') is not empty  %}
                <i class="{{ item.extra('icon') }}"></i>
            {% endif %}
            {{ block('label') }}
        </span>
    {% endif %}
{% endblock %}

from adminthemebundle.

@MartinLyne if you can, please give me your feedback so I can mark as closed or pending to fix if you still need something, thanks!

from adminthemebundle.

from adminthemebundle.